Supply missing type annotations #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nevermind - evidently it DID work and the page was giving me an old run with the same error. evidently it needed more time to refresh than I gave it. |
FoamyGuy
reviewed
Dec 19, 2022
| """Convert 0..1 Float Value to 16bit (0..65535) Range.""" | ||
| # check if value is in range | ||
| if not 0.0 <= value[0] <= 1.0: |
There was a problem hiding this comment.
It seems like maybe this was never used before? It looks like it would raise an exception error, the only place that calls this function verifies the type of value as a float before calling in to here so it could never allow this bracketed index access AFAIK.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 20, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.2.10 from 2.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#21 from dhalbert/esp32-s3-retries > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 2.0.9 from 2.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#22 from tcfranks/main > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.17 from 1.12.16: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#76 from BiffoBear/Rename_example_to_prevent_clash_with_pytest Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.5.0 from 1.4.14: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#48 from philsuth/rgb565 > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #20
submitted for review / comment