8000 use correct terminology for enable_logger() by vladak · Pull Request #141 · adafruit/Adafruit_CircuitPython_MiniMQTT · GitHub
[go: up one dir, main page]
Skip to content

use correct terminology for enable_logger() #141

New issue
< 8000 div class="mt-3 mb-2 text-center">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2023
Merged

use correct terminology for enable_logger() #141

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae9f5ca
use correct terminology for enable_logger()
vladak Jan 8, 2023
5b440f5
return the logger
vladak Jan 8, 2023
a528423
allow to specify logger name
vladak Jan 8, 2023
b24bb81
field list should end with a blank line
vladak Jan 8, 2023
9d66d9f
another blank line
vladak Jan 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions adafruit_minimqtt/adafruit_minimqtt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,16 +1074,22 @@ def is_connected(self):
return self._is_connected and self._sock is not None

# Logging
def enable_logger(self, logger, log_level=20):
"""Enables library logging provided a logger object.
def enable_logger(self, log_pkg, log_level=20, logger_name="log"):
"""Enables library logging by getting logger from the specified logging package
and setting its log level.

:param logger: A python logger pacakge.
:param log_pkg: A Python logging package.
:param log_level: Numeric value of a logging level, defaults to INFO.
:param logger_name: name of the logger, defaults to "log".

:return logger object

"""
self.logger = logger.getLogger("log")
self.logger = log_pkg.getLogger(logger_name)
self.logger.setLevel(log_level)

return self.logger

def disable_logger(self):
"""Disables logging."""
if not self.logger:
Expand Down
0