8000 use correct terminology for enable_logger() by vladak · Pull Request #141 · adafruit/Adafruit_CircuitPython_MiniMQTT · GitHub
[go: up one dir, main page]

Skip to content

use correct terminology for enable_logger() #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2023

Conversation

vladak
Copy link
Contributor
@vladak vladak commented Jan 8, 2023

I noticed that the documentation for enable_logger() talks about logger object, while it actually means logging package to create/retrieve the logger. While there I added the possibility to change logger name because by default such generic name was used so it might conflict with a logger created before interacting with adafruit_minimqtt (also given how logger creation in adafruit_logging works).

While there, I made the function return the logger object, in case someone wants to further change it (e.g. add handlers). I did this because self.logger is not preceded with _ so probably not considered private.

Copy link
Member
@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@brentru brentru merged commit 43ce775 into adafruit:main Jan 9, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 11, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1106 to 1.2.10 from 1.2.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1106#11 from greatest-gatsby/main
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.23.0 from 2.22.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#180 from FoamyGuy/fix_left_glpyh_logic

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.1.0 from 7.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#136 from vladak/user_data
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#139 from vladak/tls_port
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#141 from vladak/enable_logger_nits

Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#28 from tekktrik/dev/fix-annotations
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0