8000 Backport Add favicon to template app to fix Rails 7.2 test suite run by mgrunberg · Pull Request #8468 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Backport Add favicon to template app to fix Rails 7.2 test suite run #8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Backport Add favicon to template app to fix Rails 7.2 test suite run #8468

merged 1 commit into from
Sep 4, 2024

Conversation

mgrunberg
Copy link
Contributor

Backport #8461

@mgrunberg
add favicon for template app
62f0899 
We have some specs failing in Rails 7.2. The only hint we have in the
log is

```
No route matches [GET] "/favicon.ico" (ActionController::RoutingError)
```

Rails 7.2 new app generator does not use favicon.ico anymore. It uses a
png + meta "icon" tag.

Let's configure the icon in the template app to prevent this kind of
error.
@mgrunberg mgrunberg mentioned this pull request Sep 4, 2024
Merged
@codecov Codecov
Copy link
codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3-0-stable@da13e83). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             3-0-stable    #8468   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4963           
  Branches              ?        0           
=============================================
  Hits                  ?     4923           
  Misses                ?       40           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

javierjulio
javierjulio approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgrunberg mgrunberg merged commit 983cf3a into 3-0-stable Sep 4, 2024
19 checks passed
@mgrunberg mgrunberg deleted the backport-8461 branch September 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
type bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrunberg @javierjulio
0