Restore inner span tag to form inputs legend #8467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisahearn
commented
Sep 4, 2024
| end | ||
|
|
||
| context "with XSS payload as name" do | ||
| let :body do | ||
| build_form do |f| | ||
| f.inputs name: '<script>alert(document.domain)</script>' do | ||
| f.inputs name: "<script>alert(document.domain)</script>" do |
There was a problem hiding this comment.
This is an un-related change made by rubocop run by my IDE when the file was saved
mgrunberg
approved these changes
Sep 4, 2024
8000
|
LGTM, thanks! I don't have problems with the rubocop extra fix. Let's wait @javierjulio approval |
|
@denisahearn don't worry about the failing test. #8468 is required to fix them |
@denisahearn I merged the PR. Can you rebase your branch with 3-0-stable? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8467 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4965
Branches ? 0
=============================================
Hits ? 4925
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
@mgrunberg Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described here: #8466
Closes #8466