Cleaner test application setup #5797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f2bf8c to
7633787
Compare
|
I introduced a few extra changes here:
|
So we can ask any information about the generated application that we need.
Since it's used for more than generating the application, but also for asking information about it.
I find myself running `rm -rf tmp/rails/rails_52` or whatever and then running `bin/rake setup` to recreate the test application. Now I can do `bin/rake setup:force`.
Otherwise we will accidentally restore coverage files created by the test app creation jobs, and that will cause conflicts.
7633787 to
a0bb67f
Compare
javierjulio
reviewed
Jul 12, 2019
8000
javierjulio
approved these changes
Jul 12, 2019
|
It doesn't matter since it's just about the dev environment, but let's merge it! |
|
Thanks @javierjulio! ❤️ |
|
No problem, anytime! Thanks for making regular improvements with this. Always appreciated. |
This was referenced Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a some work I made for #5563. The idea was to be able to have a separate Gemfile including
turbolinks, run tests against it, and be able to write a regression spec for #5563 against that Gemfile. I managed to run tests against a turbolinks-enabled application, but I'm not sure why the bug didn't reproduce there either.The previous setup didn't work for the previously mentioned purpose because the test application folder name was based off the Rails version, not the gemfile name, so the different test applications for each Gemfile would collide if they used the same Rails version. This doesn't happen with the new setup and we could potentially run tests against two different Gemfiles using the same Rails version.
Since I could make having this turbolinks gemfile useful to catch the bug in #5563, this PR is not really necessary, but I guess it makes the setup more generic, so we could merge it in case we need something like this in the future.