Move test-report persistance to separate task

deivid-rodriguez · deivid-rodriguez · commit a0bb67f5c123 · 2019-07-11T18:19:38.000+02:00
Otherwise we will accidentally restore coverage files created by the
test app creation jobs, and that will cause conflicts.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -48,14 +48,18 @@ version: 2.1
     name: Create test app
     command: COVERAGE=true PARALLEL_TEST_PROCESSORS=4 bin/rake setup
 
+.restore_test_reporter: &restore_test_reporter
+  attach_workspace:
+    at: bin
+
 .restore_coverage: &restore_coverage
   attach_workspace:
     at: coverage
 
 .format_coverage: &format_coverage
   run:
     name: Format coverage
-    command: coverage/test-reporter format-coverage --input-type simplecov --output coverage/codeclimate.$CIRCLE_JOB.json
+    command: bin/test-reporter format-coverage --input-type simplecov --output coverage/codeclimate.$CIRCLE_JOB.json
 
 .save_coverage: &save_coverage
   persist_to_workspace:
@@ -68,8 +72,8 @@ version: 2.1
     name: Upload coverage results to Code Climate
     command: |
       # The parts number should match the number of jobs under upload_coverage/requires
-      coverage/test-reporter sum-coverage coverage/codeclimate.*.json --parts 20 --output coverage/codeclimate.total.json
-      coverage/test-reporter upload-coverage --input coverage/codeclimate.total.json
+      bin/test-reporter sum-coverage coverage/codeclimate.*.json --parts 20 --output coverage/codeclimate.total.json
+      bin/test-reporter upload-coverage --input coverage/codeclimate.total.json
 
 .save_test_app: &save_test_app
   persist_to_workspace:
@@ -137,7 +141,7 @@ version: 2.1
   - *save_cache
   - *restore_test_app_from_workspace
   - *restore_test_times
-  - *restore_coverage
+  - *restore_test_reporter
   - *run_tests
   - *run_features
   - *format_coverage
@@ -151,7 +155,7 @@ version: 2.1
   - *copy_current_gemfile
   - *restore_cache
   - *install_dependencies
-  - *restore_coverage
+  - *restore_test_reporter
   - *save_cache
   - *create_test_app
   - *format_coverage
@@ -167,12 +171,12 @@ jobs:
       - run:
           name: Download Code Climate test-reporter
           command: |
-            mkdir coverage
-            curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-0.6.3-linux-amd64 > coverage/test-reporter
-            chmod +x coverage/test-reporter
+            mkdir bin
+            curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-0.6.3-linux-amd64 > bin/test-reporter
+            chmod +x  bin/test-reporter
 
       - persist_to_workspace:
-          root: coverage
+          root: bin
           paths:
             - test-reporter
 
@@ -183,6 +187,7 @@ jobs:
           CC_TEST_REPORTER_ID: 8d5fcf7abea6d56c625104a9d1a81140a588a7f546f4fa9de9bc6ffc8feaaf70
 
     steps:
+      - *restore_test_reporter
       - *restore_coverage
       - *submit_coverage
 
@@ -247,7 +252,7 @@ jobs:
       - *install_dependencies
       - *save_cache
       - *generate_docs
-      - *restore_coverage
+      - *restore_test_reporter
       - *run_lints
       - *run_bug_report_template
       - *format_coverage
