8000 [887] Respect the form buffer! by seanlinsley · Pull Request #1996 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

[887] Respect the form buffer! #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2013
Merged

[887] Respect the form buffer! #1996

merged 2 commits into from
Mar 19, 2013

Conversation

seanlinsley
Copy link
Contributor

resolves #887

All it took:

# This method calls the block it's passed (in our case, the `f.inputs` block)
# and wraps the resulting HTML in a fieldset. If your block happens to return
# nil (but it otherwise built the form correctly), the below override passes
# the most recent part of the Active Admin form buffer.
def field_set_and_list_wrapping(*args, &block)
  block_given? ? super{ yield || form_buffers.last } : super
end

This was referenced Mar 16, 2013
Closed
Closed
@seanlinsley
Copy link
Contributor Author

/cc @macfanatic

seanlinsley added a commit that referenced this pull request Mar 19, 2013
@seanlinsley
Merge pull request #1996 from Daxter/bugfix/887-form-buffers
ece76d8 
[887] Respect the form buffer!
@seanlinsley seanlinsley merged commit ece76d8 into activeadmin:master Mar 19, 2013
seanlinsley added a commit that referenced this pull request Mar 25, 2013
@seanlinsley
always return a string from with_new_form_buffer
3c24a2b 
fixes `semantic_errors` regression from #1996 as per
my discussion with @coreyward in the diff for a1cfdb6
@seanlinsley seanlinsley mentioned this pull request Apr 10, 2013
Merged
@seanlinsley seanlinsley deleted the bugfix/887-form-buffers branch April 16, 2013 06:35
@seanlinsley seanlinsley mentioned this pull request Apr 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing fields just on "create" or "edit forms"
2 participants
@seanlinsley @coreyward
0