Form builder patch #1760
Closed
Form builder patch #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just waiting for Travis. |
|
Scumbag Travis. I'm pretty sure my test passes, it shouldn't break anything as well. I'll check it again. |
|
Ugh. It breaks a few tests :-(. I'll fix it soon. |
|
Grr. That's madness - jiggling form_buffers around the class... My mind is going to explode soon. Why is it so complex señor? |
| super | ||
| # Ensure the buffer is returned instead of the block result itself | ||
| form_buffers.last | ||
| end | ||
| form_buffers.last << content.html_safe | ||
| end |
There was a problem hiding this comment.
I would rewrite it like this:
def inputs(*args, &block)
@inputs_with_block = !!block_given? # Record whether a block is passed
form_buffers.last << with_new_form_buffer{ super; form_buffers.last }.html_safe
end|
@qoobaa why did you close this pull request? |
|
I wasn't able to fix the tests :-(. |
|
I crafted a working solution: #1996 :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.