8000 Upgraded npm packages to latest and cached licenses by guyarb · Pull Request #96 · actions/github-script · GitHub
[go: up one dir, main page]
Skip to content

Upgraded npm packages to latest and cached licenses #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgraded npm packages to latest and cached licenses #96

wants to merge 1 commit into from

Conversation

guyarb
Copy link
@guyarb guyarb commented Nov 11, 2020

No description provided.

@guyarb guyarb mentioned this pull request Nov 11, 2020
Merged
@guyarb
Copy link
Author
guyarb commented Nov 11, 2020 •
edited
Loading

@jclem

and please, after finishing that PR - can we release a new version?

@JJ
Copy link
Contributor
JJ commented Nov 17, 2020

Well, leaving it within v3 would help to not break existing builds... At the end of the day, there's nothing changing in the API. But I guess that's what you mean after all.

@guyarb
Copy link
Author
guyarb commented Nov 17, 2020

Well, leaving it within v3 would help to not break existing builds... At the end of the day, there's nothing changing in the API. But I guess that's what you mean after all.

Of course, I meant to keep V3 pointed to the new master.
Thanks for the clarification

@JJ
8000 Copy link
Contributor
JJ commented Nov 17, 2020

I wonder if it wouldn't make more sense to just fork this and start using forked versions?

@guyarb
Copy link
Author
guyarb commented Nov 17, 2020

I wonder if it wouldn't make more sense to just fork this and start using forked versions?

I think not
It will be only a temporary workaround. The correct way is to wait (or ping @jclem somehow) for the fix to be in the master.

@jclem
Copy link
Contributor
jclem commented Nov 17, 2020 •
edited
Loading

@guyarb Can you provide a bit more context on what's being updated in your PR description? The latest release v3.0.1 has the required actions-core update, which should fix failing workflows. I've also released an update with the latest Octokit dependencies in v3.1.0.

@jclem jclem closed this Nov 17, 2020
@jclem jclem reopened this Nov 17, 2020
@jclem
Copy link
Contributor
jclem commented Nov 17, 2020 8000

My bad, meant to hit "Comment" and hit "Close with comment" on accident.

@github-actions
Copy link

This pull request is stale because it has been open for 60 days with no activity. Remove the "Stale" label or comment on the pull request, or it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 17, 2021
@github-actions
Copy link

This pull request has been marked as stale and closed due to no activity on it.

@github-actions github-actions bot closed this Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyarb @JJ @jclem
0