8000 Bump @actions/core from 1.2.4 to 1.2.6 by dependabot[bot] · Pull Request #91 · actions/github-script · GitHub
[go: up one dir, main page]

Skip to content

Bump @actions/core from 1.2.4 to 1.2.6 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

dependabot[bot]
Copy link
Contributor
@dependabot dependabot bot commented on behalf of github Oct 5, 2020

Bumps @actions/core from 1.2.4 to 1.2.6.

Changelog

Sourced from @actions/core's changelog.

1.2.6

1.2.5

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 5, 2020
@github-actions
Copy link
github-actions bot commented Oct 5, 2020

Hello from actions/github-script! (ba43bcb)

@rstuven
Copy link
rstuven commented Oct 15, 2020

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Action authors who are using the toolkit should update the @actions/core package to v1.2.6 or greater to get the updated addPath and exportVariable functions.

@jasonmacgowan
Copy link
Contributor

@jclem can we get this merged and back ported?

@guyarb
Copy link
guyarb commented Nov 11, 2020

fixed the licenses step error in #96

@localheinz
Copy link
Contributor

Fixes #97.

@IAmHughes
Copy link
IAmHughes commented Nov 16, 2020

@jclem can we get this merged and back ported?

@jclem gentle bump here to try to get this in.

@localheinz
< 8000 /span> Copy link
Contributor
localheinz commented Nov 16, 2020

It's November 16 today, and unfortunately all my builds are failing, but if you look closely, you can see the following suggestion in the output:

The set-env command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Well, not all of my builds, only those making use of actions/github-script and running core.exportVariable().

@sfoster1
Copy link
sfoster1 commented Nov 16, 2020

It's November 16 today, and unfortunately all my builds are failing, but if you look closely, you can see the following suggestion in the output:

The set-env command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Well, not all of my builds, only those making use of actions/github-script and running core.exportVariable().

+1 to this - every build that uses this action @ v3 is going to fail going forward unless you set that environment var

sfoster1 added a commit to Opentrons/opentrons that referenced this pull request Nov 16, 2020
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/)
8000
. The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking.

The workaround is to enable the old behavior and have a message that yells at you about it.
sfoster1 added a commit to Opentrons/opentrons that referenced this pull request Nov 16, 2020
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking.

The workaround is to enable the old behavior and have a message that yells at you about it.
sfoster1 added a commit to Opentrons/opentrons that referenced this pull request Nov 16, 2020
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking.

The workaround is to enable the old behavior and have a message that yells at you about it.
@jclem jclem merged commit 9124ee0 into main Nov 17, 2020
@jclem jclem deleted the dependabot/npm_and_yarn/actions/core-1.2.6 branch November 17, 2020 13:07
@sfoster1
Copy link

@miskander @jclem didn't want my last word on this to be a complaint - thank you for getting this in and updated! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
0