-
Notifications
You must be signed in to change notification settings - Fork 462
Bump @actions/core from 1.2.4 to 1.2.6 #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.4 to 1.2.6. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Signed-off-by: dependabot[bot] <support@github.com>
Hello from actions/github-script! (ba43bcb) |
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
|
@jclem can we get this merged and back ported? |
fixed the licenses step error in #96 |
Fixes #97. |
It's November 16 today, and unfortunately all my builds are failing, but if you look closely, you can see the following suggestion in the output:
Well, not all of my builds, only those making use of |
+1 to this - every build that uses this action @ v3 is going to fail going forward unless you set that environment var |
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/) 8000 . The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking. The workaround is to enable the old behavior and have a message that yells at you about it.
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking. The workaround is to enable the old behavior and have a message that yells at you about it.
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking. The workaround is to enable the old behavior and have a message that yells at you about it.
@miskander @jclem didn't want my last word on this to be a complaint - thank you for getting this in and updated! Much appreciated. |
Bumps @actions/core from 1.2.4 to 1.2.6.
Changelog
Sourced from @actions/core's changelog.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.