-
Notifications
You must be signed in to change notification settings - Fork 38.9k
Update README.md #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having to change 'xit's in exercises like repeatString for testing exercise solutions was not immediately obvious. I felt it should be mentioned so newbies before me won't face confusing jasmine messages about xits when testing their code. I don't know how the wording of the readme is really intended, so I hope my change will address this properly.
gah! Good catch! This is the change that i had made that we lost when I undid my stupid 'solutions' merge. Thanks for this PR 👍 |
willgodev
pushed a commit
to willgodev/javascript-exercises
that referenced
this pull request
Dec 21, 2020
Update README.md
milanmomcilovic96
added a commit
to milanmomcilovic96/javascript-exercises
that referenced
this pull request
Jan 28, 2022
RSBlackrose
added a commit
to RSBlackrose/javascript-exercises
that referenced
this pull request
Mar 12, 2022
risseado
pushed a commit
to risseado/javascript-exercises
that referenced
this pull request
Apr 9, 2022
Quick word change in comment
ronsamgeorge
added a commit
to ronsamgeorge/javascript-exercises
that referenced
this pull request
Apr 24, 2022
JFerrettUK
added a commit
to JFerrettUK/javascript-exercises
that referenced
this pull request
Jun 5, 2022
larantula
added a commit
to larantula/javascript-exercises
that referenced
this pull request
Jun 17, 2022
bmilcs
added a commit
to bmilcs/odin-javascript-exercises
that referenced
this pull request
Jul 25, 2022
bmilcs
added a commit
to bmilcs/odin-javascript-exercises
that referenced
this pull request
Jul 25, 2022
k-fields
pushed a commit
to k-fields/javascript-exercises
that referenced
this pull request
Aug 10, 2022
Namin404
added a commit
to Namin404/javascript-exercises
that referenced
this pull request
Aug 18, 2022
sinahuss
added a commit
to sinahuss/javascript-exercises
that referenced
this pull request
Aug 20, 2022
Supablu
added a commit
to Supablu/javascript-exercises
that referenced
this pull request
Sep 20, 2022
nathenialalleyne
added a commit
to nathenialalleyne/javascript-exercises
that referenced
this pull request
Sep 27, 2022
mikiyabu
added a commit
to mikiyabu/javascript-exercises
that referenced
this pull request
Oct 2, 2022
tilenmars
added a commit
to tilenmars/javascript-exercises
that referenced
this pull request
Oct 30, 2022
tilenmars
added a commit
to tilenmars/javascript-exercises
that referenced
this pull request
Oct 30, 2022
sunny852206
added a commit
to sunny852206/javascript-exercises
that referenced
this pull request
Nov 2, 2022
Endeared
added a commit
to Endeared/javascript-exercises
that referenced
this pull request
Dec 3, 2022
rdansie
added a commit
to rdansie/javascript-exercises
that referenced
this pull request
Dec 19, 2022
jpawz
added a commit
to jpawz/javascript-exercises
that referenced
this pull request
Jan 8, 2023
DomenicoDErasmo
added a commit
to DomenicoDErasmo/javascript-exercises
that referenced
this pull request
Jan 11, 2023
Kenfresno
added a commit
to Kenfresno/odin-javascript-exercises
that referenced
this pull request
Jan 31, 2023
bmoran17
added a commit
to bmoran17/javascript-exercises
that referenced
this pull request
Feb 19, 2023
…t pass all tests
ericoptorres
added a commit
to ericoptorres/javascript-exercises-odin
that referenced
this pull request
Mar 24, 2023
danielrsouza10
added a commit
to danielrsouza10/javascript-exercises
that referenced
this pull request
Apr 2, 2023
NeilMartinRobertson
added a commit
to NeilMartinRobertson/javascript-exercises
that referenced
this pull request
Apr 6, 2023
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 5, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 5, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 12, 2024
korybiggerstaff
added a commit
to korybiggerstaff/javascript-exercises
that referenced
this pull request
Mar 13, 2024
ycaglar
added a commit
to ycaglar/javascript-exercises
that referenced
this pull request
Mar 24, 2024
NadifRahman
added a commit
to NadifRahman/javascript-exercises
that referenced
this pull request
Apr 28, 2024
theankushgautam
added a commit
to theankushgautam/odin-javascript-exercises
that referenced
this pull request
May 13, 2024
SLajuwomi
added a commit
to SLajuwomi/odin-javascript-exercises
that referenced
this pull request
Jul 4, 2024
bbrockbrown
added a commit
to bbrockbrown/javascript-exercises
that referenced
this pull request
Jul 27, 2024
Chegarrito
added a commit
to Chegarrito/the-odin-project-javascript-exercises
that referenced
this pull request
Jul 30, 2024
ImJasc
added a commit
to ImJasc/javascript-exercises
that referenced
this pull request
Aug 14, 2024
ImJasc
added a commit
to ImJasc/javascript-exercises
that referenced
this pull request
Aug 14, 2024
ImJasc
added a commit
to ImJasc/javascript-exercises
that referenced
this pull request
Aug 14, 2024
pserighelli
added a commit
to pserighelli/javascript-exercises
that referenced
this pull request
Sep 10, 2024
chris-gr81
added a commit
to chris-gr81/javascript-exercises
that referenced
this pull request
Sep 27, 2024
lonlich
pushed a commit
to lonlich/javascript-exercises
that referenced
this pull request
Oct 8, 2024
ssaigol
added a commit
to ssaigol/javascript-exercises
that referenced
this pull request
Oct 9, 2024
RemanthManyam
added a commit
to RemanthManyam/javascript-exercises
that referenced
this pull request
Oct 25, 2024
j-slopey
added a commit
to j-slopey/javascript-exercises
that referenced
this pull request
Dec 11, 2024
mwsepulveda
added a commit
to mwsepulveda/javascript-exercises-top
that referenced
this pull request
Jan 3, 2025
Neon-Panda
added a commit
to Neon-Panda/javascript-exercises
that referenced
this pull request
Jan 14, 2025
Oussama5379
added a commit
to Oussama5379/javascript-exercises
that referenced
this pull request
Feb 1, 2025
Update README.md
Evelio35
added a commit
to Evelio35/javascript-exercises
that referenced
this pull request
Feb 15, 2025
Evelio35
added a commit
to Evelio35/javascript-exercises
that referenced
this pull request
Feb 18, 2025
Evelio35
added a commit
to Evelio35/javascript-exercises
that referenced
this pull request
Feb 18, 2025
Roo-CS
added a commit
to Roo-CS/The-Odin-Project-Javascript-Exercises
that referenced
this pull request
Feb 25, 2025
… removeFromArray method
ignasc
added a commit
to ignasc/javascript-exercises
that referenced
this pull request
Mar 12, 2025
mp-v99
added a commit
to mp-v99/javascript-exercises
that referenced
this pull request
Mar 13, 2025
ZBO-R8io
added a commit
to ZBO-R8io/javascript-exercises
that referenced
this pull request
Apr 8, 2025
Sulemank-1
added a commit
to Sulemank-1/javascript-exercises
that referenced
this pull request
Apr 16, 2025
Copied the solution because I couldn't solve the exercise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to change 'xit's in exercises like repeatString for testing exercise solutions was not immediately obvious. I felt it should be mentioned so newbies before me won't face confusing jasmine messages about xits when testing their code.
I don't know how the wording of the readme is really intended, so I hope my change will address this properly.