8000 Solve #4 · tilenmars/javascript-exercises@2d47b9c · GitHub
[go: up one dir, main page]

Skip to content

Commit 2d47b9c

Browse files
committed
1 parent 6b79a6e commit 2d47b9c

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

04_removeFromArray/removeFromArray.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
const removeFromArray = function(arr, del) {
2-
3-
//del -= 1;
42
let index;
5-
for (let i = 1; i < arguments.length; i++) {
6-
index = arr.indexOf(arguments[i]);
7-
arr.splice(index, 1);
3+
for (let i = 1; i <= arguments.length; i++) {
4+
if (arr.includes(arguments[i])) {
5+
index = arr.indexOf(arguments[i]);
6+
arr.splice(index, 1);
7+
}
88
}
99
return arr;
1010
};

04_removeFromArray/removeFromArray.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ describe('removeFromArray', () => {
77
test('removes multiple values', () => {
88
expect(removeFromArray([1, 2, 3, 4], 3, 2)).toEqual([1, 4]);
99
});
10-
test.skip('ignores non present values', () => {
10+
test('ignores non present values', () => {
1111
expect(removeFromArray([1, 2, 3, 4], 7, "tacos")).toEqual([1, 2, 3, 4]);
1212
});
13-
test.skip('ignores non present values, but still works', () => {
13+
test('ignores non present values, but still works', () => {
1414< 902A /td>
expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]);
1515
});
16-
test.skip('can remove all values', () => {
16+
test('can remove all values', () => {
1717
expect(removeFromArray([1, 2, 3, 4], 1, 2, 3, 4)).toEqual([]);
1818
});
19-
test.skip('works with strings', () => {
19+
test('works with strings', () => {
2020
expect(removeFromArray(["hey", 2, 3, "ho"], "hey", 3)).toEqual([2, "ho"]);
2121
});
22-
test.skip('only removes same type', () => {
22+
test('only removes same type', () => {
2323
expect(removeFromArray([1, 2, 3], "1", 3)).toEqual([1, 2]);
2424
});
2525
});

0 commit comments

Comments
 (0)
0