8000 Refactor, remove symlink pylib/Lib -> Lib and moved path by Undersk0re · Pull Request #5763 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Refactor, remove symlink pylib/Lib -> Lib and moved path #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Refactor, remove symlink pylib/Lib -> Lib and moved path #5763

wants to merge 6 commits into from

Conversation

Undersk0re
Copy link
Contributor

Overview

refactor: reorganized Lib folder structure and updated symlinks

  • moved Lib to pylib/Lib and inverted the symlinks accordingly
  • tested using pdc.sh before and after the refactor
  • no functional changes, only path adjustments

pdc.sh log before refactor

== Tests result: FAILURE ==

292 tests OK.

2 tests failed:
    test_rlcompleter test_support

14 tests skipped:
    test_android test_audit test_compile test_ctypes test_devpoll
    test_kqueue test_multiprocessing_main_handling test_smtpnet
    test_socketserver test_sqlite3 test_urllib2net test_urllibnet
    test_winapi test_zipfile64

Total duration: 19 min 22 sec
Tests result: FAILURE
./pdc.sh: riga 49: pytest: comando non trovato


*********************
PDC failed
     Fail cargo clippy --all -- -Dwarnings
     Fail cargo test --all
     Fail cargo run --release -- -m test -v
     Fail pytest

pdc.sh log after refactor

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK (skipped=2)
test_zoneinfo passed

== Tests result: FAILURE ==

292 tests OK.

2 tests failed:
    test_rlcompleter test_support

14 tests skipped:
    test_android test_audit test_compile test_ctypes test_devpoll
    test_kqueue test_multiprocessing_main_handling test_smtpnet
    test_socketserver test_sqlite3 test_urllib2net test_urllibnet
    test_winapi test_zipfile64

Total duration: 17 min 54 sec
Tests result: FAILURE
./pdc.sh: riga 49: pytest: comando non trovato


*********************
PDC failed
     Fail cargo clippy --all -- -Dwarnings
     Fail cargo test --all
     Fail cargo run --release -- -m test -v
     Fail pytest

@Undersk0re
Copy link
B6F8 Contributor Author

recommitted #5746 because i have not the permission to reopen pull requests

@arihant2math
Copy link
Collaborator
arihant2math commented Apr 30, 2025 •
edited
Loading

GH Actions needs to be patched, because it expects Lib/. Additionally this has to be rebased over main due to conflicts.

@Undersk0re
Copy link
Contributor Author

Switching using Rust path references is a quicker and more stable solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Undersk0re @arihant2math
0