8000 Remove symlink to deduplicate some code by Undersk0re · Pull Request #5746 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

Remove symlink to deduplicate some code #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Remove symlink to deduplicate some code #5746

wants to merge 0 commits into from

Conversation

Undersk0re
Copy link
Contributor

Overview

refactor: reorganized Lib folder structure and updated symlinks

  • moved Lib to pylib/Lib and inverted the symlinks accordingly
  • tested using pdc.sh before and after the refactor
  • no functional changes, only path adjustments

pdc.sh log before refactor

== Tests result: FAILURE ==

292 tests OK.

2 tests failed:
    test_rlcompleter test_support

14 tests skipped:
    test_android test_audit test_compile test_ctypes test_devpoll
    test_kqueue test_multiprocessing_main_handling test_smtpnet
    test_socketserver test_sqlite3 test_urllib2net test_urllibnet
    test_winapi test_zipfile64

Total duration: 19 min 22 sec
Tests result: FAILURE
./pdc.sh: riga 49: pytest: comando non trovato


*********************
PDC failed
     Fail cargo clippy --all -- -Dwarnings
     Fail cargo test --all
     Fail cargo run --release -- -m test -v
     Fail pytest

pdc.sh log after refactor

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK (skipped=2)
test_zoneinfo passed

== Tests result: FAILURE ==

292 tests OK.

2 tests failed:
    test_rlcompleter test_support

14 tests skipped:
    test_android test_audit test_compile test_ctypes test_devpoll
    test_kqueue test_multiprocessing_main_handling test_smtpnet
    test_socketserver test_sqlite3 test_urllib2net test_urllibnet
    test_winapi test_zipfile64

Total duration: 17 min 54 sec
Tests result: FAILURE
./pdc.sh: riga 49: pytest: comando non trovato


*********************
PDC failed
     Fail cargo clippy --all -- -Dwarnings
     Fail cargo test --all
     Fail cargo run --release -- -m test -v
     Fail pytest

@arihant2math
Copy link
Collaborator

I think Lib/ should stay where it is, because cpython does it like that.
(I'm speaking for myself here, I don't know what others think)

@youknowone
Copy link
Member

I also usually regarded it as common python implementation convention. But except for the convention, no idea to not to do it.

@coolreader18 do you have any comment?

@Undersk0re
Copy link
Contributor Author

I moved the folder not necessarily to the best location, but to have a single entry point for the Python library and avoid confusing developers in a complex project.

pylib/Lib and Lib in their original locations are also fine for me; at this point, would it be possible to try removing the symlink in pylib/Lib, if that's not an issue?

@Undersk0re Undersk0re closed this Apr 27, 2025
@youknowone
Copy link
Member

Could you open it again?

@Undersk0re
Copy link
Contributor Author

If this is the correct state, I shouldn't have permission to do it with this account. @youknowone

@youknowone
Copy link
Member

You pushed the past commit to the PR branch. Please open a new one.

@Undersk0re
Copy link
Contributor Author

it will be done

@Undersk0re Undersk0re mentioned this pull request Apr 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Undersk0re @arihant2math @youknowone
0