8000 [ci] Install missing macOS GHA pip3.11 by svenevs · Pull Request #262 · RobotLocomotion/drake-external-examples · GitHub
[go: up one dir, main page]

Skip to content

[ci] Install missing macOS GHA pip3.11 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

svenevs
Copy link
Contributor
@svenevs svenevs commented Feb 16, 2023

Continuation of the saga: #250, #252, #257, #259.


This change is Reviewable

@svenevs svenevs force-pushed the fix/macos-gha-brew-python-again-again-again-AGAIN branch from 82c964a to 2f7d66b Compare February 16, 2023 15:48
@svenevs svenevs force-pushed the fix/macos-gha-brew-python-again-again-again-AGAIN branch from 2f7d66b to aeb3f19 Compare February 16, 2023 15:52
Copy link
Contributor Author
@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: who knows how long it'll work this time, my assumption is it will break again and we'll put another bandaid on. There doesn't seem to be any holistically resilient answer.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)


.github/workflows/ci.yml line 68 at r1 (raw file):

          # On 2023-02-16 the pip3.11 symlink was mysteriously missing.
          brew unlink python@3.11 && brew link python@3.11
          pip3.11 --version

FYI from the build log:

Unlinking /usr/local/Cellar/python@3.11/3.11.1... 5 symlinks removed.
Linking /usr/local/Cellar/python@3.11/3.11.1... 11 symlinks created.

No idea why 5 were there originally, theoretically the previous steps should have been removing the symlinks in the first place?

Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)

Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)

svenevs
Copy link
Contributor Author
@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sammy-tri for platform review, per schedule please. TLDR yet another bandaid, it works for now so we'd like to merge it. Another bandaid will likely need to be applied in the future AKA we don't have a "proper" fix for this and haven't for weeks.

Reviewable status: all discussions resolved, LGTM missing from assignee sammy-tri, platform LGTM missing (waiting on @sammy-tri)

Copy link
@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: (rubber stamp for trust in the authors rather than understanding exactly whats going on here)

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [sammy-tri] (waiting on @svenevs)

@svenevs svenevs merged commit 5d1d00e into main Feb 16, 2023
@svenevs svenevs deleted the fix/macos-gha-brew-python-again-again-again-AGAIN branch February 16, 2023 21:12
RussTedrake added a commit to RussTedrake/htmlbook that referenced this pull request Feb 17, 2023
RussTedrake added a commit to RussTedrake/htmlbook that referenced this pull request Feb 17, 2023
svenevs added a commit that referenced this pull request Feb 24, 2023
New failures related to `brew upgrade`, unrelated to python.

Partial continuation of: #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Feb 24, 2023
New failures related to `brew upgrade`, unrelated to python.

Partial continuation of: #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Apr 6, 2023
New failures related to brew upgrade on `go`, fix the same way
as #263.  Partial continuation of #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Apr 6, 2023
New failures related to brew upgrade on `go`, fix the same way
as #263.  Partial continuation of #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Apr 6, 2023
New failures related to brew upgrade on `go`, fix the same way
as #263.  Partial continuation of #250, #252, #257, #259, #262.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0