-
Notifications
You must be signed in to change notification settings - Fork 55
[ci] Install missing macOS GHA pip3.11 #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Install missing macOS GHA pip3.11 #262
Conversation
82c964a
to
2f7d66b
Compare
2f7d66b
to
aeb3f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who knows how long it'll work this time, my assumption is it will break again and we'll put another bandaid on. There doesn't seem to be any holistically resilient answer.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)
.github/workflows/ci.yml
line 68 at r1 (raw file):
# On 2023-02-16 the pip3.11 symlink was mysteriously missing. brew unlink python@3.11 && brew link python@3.11 pip3.11 --version
FYI from the build log:
Unlinking /usr/local/Cellar/python@3.11/3.11.1... 5 symlinks removed.
Linking /usr/local/Cellar/python@3.11/3.11.1... 11 symlinks created.
No idea why 5
were there originally, theoretically the previous steps should have been removing the symlinks in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sammy-tri for platform review, per schedule please. TLDR yet another bandaid, it works for now so we'd like to merge it. Another bandaid will likely need to be applied in the future AKA we don't have a "proper" fix for this and haven't for weeks.
Reviewable status: all discussions resolved, LGTM missing from assignee sammy-tri, platform LGTM missing (waiting on @sammy-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(rubber stamp for trust in the authors rather than understanding exactly whats going on here)
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [sammy-tri] (waiting on @svenevs)
Continuation of the saga: #250, #252, #257, #259.
This change is