-
Notifications
You must be signed in to change notification settings - Fork 55
[setup] Hotfix for brew upgrade failing on python@3.10 #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51f4bed
to
2a896aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@BetsyMcPhail for review please.
Reviewed all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
.github/workflows/ci.yml
line 69 at r1 (raw file):
rm -f /usr/local/bin/pydoc3 rm -f /usr/local/bin/python3 rm -f /usr/local/bin/python3-config
FYI if you look at the logs
Unlinking /usr/local/Cellar/python@3.10/3.10.8... 19 symlinks removed.
Unlinking /usr/local/Cellar/python@3.8/3.8.15... 11 symlinks removed.
Unlinking /usr/local/Cellar/python@3.10/3.10.8... 0 symlinks removed.
Unlinking /usr/local/Cellar/python@3.11/3.11.0... 5 symlinks removed.
Even afterward the brew update
and brew upgrade python@3.10
(in this section because where it happens doesn't matter, and this finds the issue faster in CI) I had to remove these. This is clearly a brew problem, I'd like to just keep this hack in here as is and we can remove it in the python 3.11 PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
.github/workflows/ci.yml
line 69 at r1 (raw file):
Previously, svenevs (Stephen McDowell) wrote…
FYI if you look at the logs
Unlinking /usr/local/Cellar/python@3.10/3.10.8... 19 symlinks removed. Unlinking /usr/local/Cellar/python@3.8/3.8.15... 11 symlinks removed. Unlinking /usr/local/Cellar/python@3.10/3.10.8... 0 symlinks removed. Unlinking /usr/local/Cellar/python@3.11/3.11.0... 5 symlinks removed.
Even afterward the
brew update
andbrew upgrade python@3.10
(in this section because where it happens doesn't matter, and this finds the issue faster in CI) I had to remove these. This is clearly a brew problem, I'd like to just keep this hack in here as is and we can remove it in the python 3.11 PR.
BTW link for convenience: https://github.com/RobotLocomotion/drake-external-examples/actions/runs/3716386279/jobs/6302647959
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @svenevs)
.github/workflows/ci.yml
line 48 at r1 (raw file):
- name: checkout uses: actions/checkout@v2 # NOTE: on 2022-12-16 there were build failures being unable to
Nit make a drake-style TODO that states we can remove when we update to Python 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @svenevs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @svenevs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @svenevs)
The GitHub Actions runner seems to have conflicting symlinks to /usr/local/bin and one must be chosen.
2a896aa
to
f9c419c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @svenevs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)
Continuation of #250. Relates: https://github.com/actions/setup-python/issues/577
Continuation of #250. Relates: https://github.com/actions/setup-python/issues/577
Continuation of #250. Relates: https://github.com/actions/setup-python/issues/577
The GitHub Actions runner seems to have conflicting symlinks to /usr/local/bin and one must be chosen.
This change is