8000 [setup] Hotfix for brew upgrade failing on python@3.10 by svenevs · Pull Request #250 · RobotLocomotion/drake-external-examples · GitHub
[go: up one dir, main page]

Skip to content

[setup] Hotfix for brew upgrade failing on python@3.10 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

svenevs
Copy link
Contributor
@svenevs svenevs commented Dec 16, 2022

The GitHub Actions runner seems to have conflicting symlinks to /usr/local/bin and one must be chosen.


This change is Reviewable

@svenevs svenevs mentioned this pull request Dec 16, 2022
2 tasks
@svenevs svenevs force-pushed the fix/python310-macos-brew-upgrade-fail branch 7 times, most recently from 51f4bed to 2a896aa Compare December 16, 2022 20:39
Copy link
Contributor Author
@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@BetsyMcPhail for review please.

Reviewed all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)


.github/workflows/ci.yml line 69 at r1 (raw file):

          rm -f /usr/local/bin/pydoc3
          rm -f /usr/local/bin/python3
          rm -f /usr/local/bin/python3-config

FYI if you look at the logs

Unlinking /usr/local/Cellar/python@3.10/3.10.8... 19 symlinks removed.
Unlinking /usr/local/Cellar/python@3.8/3.8.15... 11 symlinks removed.
Unlinking /usr/local/Cellar/python@3.10/3.10.8... 0 symlinks removed.
Unlinking /usr/local/Cellar/python@3.11/3.11.0... 5 symlinks removed.

Even afterward the brew update and brew upgrade python@3.10 (in this section because where it happens doesn't matter, and this finds the issue faster in CI) I had to remove these. This is clearly a brew problem, I'd like to just keep this hack in here as is and we can remove it in the python 3.11 PR.

Copy link
Contributor Author
@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)


.github/workflows/ci.yml line 69 at r1 (raw file):

Previously, svenevs (Stephen McDowell) wrote…

FYI if you look at the logs

Unlinking /usr/local/Cellar/python@3.10/3.10.8... 19 symlinks removed.
Unlinking /usr/local/Cellar/python@3.8/3.8.15... 11 symlinks removed.
Unlinking /usr/local/Cellar/python@3.10/3.10.8... 0 symlinks removed.
Unlinking /usr/local/Cellar/python@3.11/3.11.0... 5 symlinks removed.

Even afterward the brew update and brew upgrade python@3.10 (in this section because where it happens doesn't matter, and this finds the issue faster in CI) I had to remove these. This is clearly a brew problem, I'd like to just keep this hack in here as is and we can remove it in the python 3.11 PR.

BTW link for convenience: https://github.com/RobotLocomotion/drake-external-examples/actions/runs/3716386279/jobs/6302647959

Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @svenevs)


.github/workflows/ci.yml line 48 at r1 (raw file):

      - name: checkout
        uses: actions/checkout@v2
      # NOTE: on 2022-12-16 there were build failures being unable to

Nit make a drake-style TODO that states we can remove when we update to Python 3.11

Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 unresolved discussions, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @svenevs)

Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed - :lgtm:

Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @svenevs)

Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @svenevs)

The GitHub Actions runner seems to have conflicting symlinks
to /usr/local/bin and one must be chosen.
@svenevs svenevs force-pushed the fix/python310-macos-brew-upgrade-fail branch from 2a896aa to f9c419c Compare December 16, 2022 22:06
Copy link
Contributor
@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM missing (waiting on @svenevs)

Copy link
Contributor Author
@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all discussions resolved, platform LGTM missing (waiting on @svenevs)

@svenevs svenevs merged commit afdcf92 into main Dec 16, 2022
@svenevs svenevs deleted the fix/python310-macos-brew-upgrade-fail branch December 16, 2022 23:17
svenevs added a commit that referenced this pull request Jan 20, 2023
GitHub appears to have updated the macOS runners today,
python@3.8 is no longer installed.

brew update && brew upgrade works again, so we are reverting
#250 and #252 together.
svenevs added a commit that referenced this pull request Feb 8, 2023
svenevs added a commit that referenced this pull request Feb 8, 2023
svenevs added a commit that referenced this pull request Feb 8, 2023
svenevs added a commit that referenced this pull request Feb 8, 2023
svenevs added a commit that referenced this pull request Feb 8, 2023
svenevs added a commit that referenced this pull request Feb 16, 2023
svenevs added a commit that referenced this pull request Feb 16, 2023
svenevs added a commit that referenced this pull request Feb 16, 2023
svenevs added a commit that referenced this pull request Feb 16, 2023 67E6
svenevs added a commit that referenced this pull request Feb 24, 2023
New failures related to `brew upgrade`, unrelated to python.

Partial continuation of: #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Feb 24, 2023
New failures related to `brew upgrade`, unrelated to python.

Partial continuation of: #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Apr 6, 2023
New failures related to brew upgrade on `go`, fix the same way
as #263.  Partial continuation o
A3E2
f #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Apr 6, 2023
New failures related to brew upgrade on `go`, fix the same way
as #263.  Partial continuation of #250, #252, #257, #259, #262.
svenevs added a commit that referenced this pull request Apr 6, 2023
New failures related to brew upgrade on `go`, fix the same way
as #263.  Partial continuation of #250, #252, #257, #259, #262.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0