8000 Fix capitalization cases for PoshChan by RDIL · Pull Request #9188 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix capitalization cases for PoshChan#9188

Merged
TravisEz13 merged 8 commits intoPowerShell:masterfrom
RDIL:patch-5
Mar 23, 2019
Merged

Fix capitalization cases for PoshChan#9188
TravisEz13 merged 8 commits intoPowerShell:masterfrom
RDIL:patch-5

Conversation

@RDIL
Copy link
Contributor
@RDIL RDIL commented Mar 21, 2019 •
edited
Loading

PR Summary

The jobs name is fully lowercase
Fixes the issue found by @iSazonov

PR Context

PR Checklist

@RDIL RDIL mentioned this pull request Mar 21, 2019
Merged
3 tasks
@RDIL RDIL changed the title Fix macOS Fix macOS for PoshChan Mar 21, 2019
@iSazonov iSazonov requested a review from SteveL-MSFT March 21, 2019 19:17
@iSazonov
Copy link
Collaborator
iSazonov commented Mar 21, 2019

The same for "linux"

@SteveL-MSFT Can it be case-insensetive?

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

@PoshChan Please rebuild mAcOS

@PoshChan
Copy link
Collaborator
PoshChan commented Mar 23, 2019

@SteveL-MSFT, could not find a matching build target

@RDIL
Copy link
Contributor Author
RDIL commented Mar 23, 2019

@SteveL-MSFT typo

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

@RDIL testing case-insensitivity which is what I expected

@RDIL
Copy link
Contributor Author
RDIL commented Mar 23, 2019

Oh

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

Intent was to be case-insensitive, but forgot that ConvertFrom-Json -AsHashTable results in a case-sensitive hashtable. I believe I can fix this on the server side.

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

@PoshChan-Staging Please rebuild MACos

@PoshChan-Staging
Copy link
Collaborator
PoshChan-Staging commented Mar 23, 2019

@SteveL-MSFT, successfully started rebuild of PowerShell-CI-macOS

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

@PoshChan please rebuild linux

@PoshChan
Copy link
Collaborator
PoshChan commented Mar 23, 2019

@SteveL-MSFT, all requests start with the magic word Please.

@RDIL
Copy link
Contributor Author
RDIL commented Mar 23, 2019

lol

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

@PoshChan-Staging please rebuild LINux

@PoshChan-Staging
Copy link
Collaborator
PoshChan-Staging commented Mar 23, 2019

@SteveL-MSFT, successfully started rebuild of PowerShell-CI-Linux

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

@PoshChan pLeASE rEbuild wINDOws

@PoshChan
Copy link
Collaborator
PoshChan commented Mar 23, 2019

@SteveL-MSFT, successfully started rebuild of PowerShell-CI-windows

@SteveL-MSFT
Copy link
Member
SteveL-MSFT commented Mar 23, 2019

Ok, I believe @PoshChan is fully case-insensitive now :)

So, this PR isn't necessary except for aesthetic reasons. But then you might as well fix Windows, macOS, and Linux with "correct" casing :)

@RDIL RDIL changed the title Fix macOS for PoshChan Fix capitalization cases for PoshChan Mar 23, 2019
SteveL-MSFT
SteveL-MSFT requested changes Mar 23, 2019
View reviewed changes
SteveL-MSFT and others added 2 commits March 23, 2019 08:43
@SteveL-MSFT @RDIL
Update .poshchan/settings.json
eaadb75 
Co-Authored-By: RDIL <me@rdil.rocks>
@SteveL-MSFT @RDIL
Update .poshchan/settings.json
d163ed6 
Co-Authored-By: RDIL <me@rdil.rocks>
@SteveL-MSFT @RDIL
Update .poshchan/settings.json
ffcfae7 
Co-Authored-By: RDIL <me@rdil.rocks>
@TravisEz13 TravisEz13 merged commit c0cce10 into PowerShell:master Mar 23, 2019
@RDIL RDIL deleted the patch-5 branch March 23, 2019 20:33
@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 29, 2019
@TravisEz13 TravisEz13 added CL-Tools Indicates that a PR should be marked as a tools change in the Change Log and removed CL-Untagged labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.0.0-preview.1

Development

Successfully merging this pull request may close these issues.

6 participants

@RDIL @iSazonov @SteveL-MSFT @PoshChan @PoshChan-Staging @TravisEz13
0