8000 Update feature-request issue template to move instructions into comments. by mklement0 · Pull Request #9187 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Update feature-request issue template to move instructions into comments.#9187

Merged
TravisEz13 merged 4 commits intoPowerShell:masterfrom
mklement0:patch-1
Mar 22, 2019
Merged

Update feature-request issue template to move instructions into comments.#9187
TravisEz13 merged 4 commits intoPowerShell:masterfrom
mklement0:patch-1

Conversation

@mklement0
Copy link
Contributor
@mklement0 mklement0 commented Mar 21, 2019

PR Summary

Moved instructions into comments.

PR Context

While users should see instructions, they shouldn't be included when the issue is created.

PR Checklist

Moved instructions into comments.
@mklement0 mklement0 changed the title Update Feature_Request.md to move instructions into comments. Update feature-request issue template to move instructions into comments. Mar 21, 2019
@vexx32
Copy link
Collaborator
vexx32 commented Mar 21, 2019

@mklement0 for those users who don't know the markdown / html syntax all that well, might be worth mentioning that anything put inside the comment body won't be displayed and they should either remove them or put text outside the comments.

@mklement0
Copy link
Contributor Author

That's a good idea, @vexx32, but I personally feel I've put in my time 😁

If someone wants to take that on, note that it should also be done for the other templates; it's missing from the bug template too.

It's also worth improving the templates that essentially say: "Do not create an issue here, just read this text and then take appropriate action elsewhere".

It sounds like preventing users from still creating an issue cannot be prevented for technical reasons, so the next best thing is to add a note at the top that shouts "DO NOT CREATE AN ISSUE - JUST READ".

@@ -9,11 +9,15 @@ assignees: ''

Copy link
Contributor
@RDIL RDIL Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the top

Suggested change
<!--anything that looks like this is a comment and cannot be seen after creating the issue.-->

dont accept

@iSazonov
Copy link
Collaborator

@PoshChan rebuild macos

@PoshChan-Staging
Copy link
Collaborator

@iSazonov, I do not 8000 understand: rebuild macos

1 similar comment
@PoshChan
Copy link
Collaborator

@iSazonov, I do not understand: rebuild macos

@iSazonov
Copy link
Collaborator

@PoshChan Please rebuild macos

@PoshChan
Copy link
Collaborator

@iSazonov, did not find matching build context: PowerShell-CI-macOS; allowed contexts: PowerShell-CI-windows, PowerShell-CI-linux, PowerShell-CI-static-analysis

@PoshChan-Staging
Copy link
Collaborator

@iSazonov, you are not authorized to request a rebuild

@iSazonov
Copy link
Collaborator

@SteveL-MSFT Could you please look the issue with PoshChan ?

@RDIL
Copy link
Contributor
RDIL commented Mar 21, 2019

@iSazonov it’s a config issue

@TravisEz13 TravisEz13 self-assigned this Mar 21, 2019
@TravisEz13
Copy link
Member

@PoshChan Please remind me in 22 hours

@PoshChan
Copy link
Collaborator

@TravisEz13, will remind you in 22 hours

@PoshChan-Staging
Copy link
Collaborator

@TravisEz13, you are not authorized to request a reminder

@RDIL
Copy link
Contributor
RDIL commented Mar 21, 2019

@iSazonov fixed in #9188

@PoshChan
Copy link
Collaborator

@TravisEz13, this is the reminder you requested 22 hours ago

@RDIL
Copy link
Contributor
RDIL commented Mar 22, 2019

The reminder you were 'not authorized' to request 😆

@SteveL-MSFT
Copy link
Member

@PoshChan Please remind me in 1 minute

@PoshChan-Staging
Copy link
Collaborator

@SteveL-MSFT, will remind you in 1 minute

1 similar comment
@PoshChan
Copy link
Collaborator

@SteveL-MSFT, will remind you in 1 minute

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, this is the reminder you requested 1 minute ago

@SteveL-MSFT
Copy link
Member

Ignore @PoshChan-Staging, need to update her to not respond to @PoshChan requests. Staging is intended for testing before rolling out to @PoshChan. I believe it's fixed now.

Copy link
Collaborator

@PoshChan Please rebuild macos

@PoshChan
Copy link
Collaborator

@iSazonov, did not find matching build context: PowerShell-CI-macOS; allowed contexts: PowerShell-CI-windows, PowerShell-CI-linux, PowerShell-CI-static-analysis

@iSazonov
Copy link
Collaborator

@PoshChan Please rebuild macOS

@PoshChan
Copy link
Collaborator

@iSazonov, could not find a matching build target

@iSazonov
Copy link
Collaborator

@PoshChan Please rebuild PowerShell-CI-macOS

@PoshChan
Copy link
Collaborator

@iSazonov, I do not understand the build target(s) PowerShell-CI-macOS; I only allow all, windows, staging, linux, macos

@iSazonov
Copy link
Collaborator

@PoshChan Please rebuild linux

@PoshChan
Copy link
Collaborator

@iSazonov, successfully started rebuild of PowerShell-CI-Linux

@iSazonov
Copy link
Collaborator

@SteveL-MSFT The bot can not rebuild macos if status is

PowerShell-CI-macos Expected — Waiting for status to be reported

Is it possible to fix this?

@PoshChan-Staging
Copy link
Collaborator

@SteveL-MSFT, this is the reminder you requested 1 minute ago

@TravisEz13 TravisEz13 merged commit f81f778 into PowerShell:master Mar 22, 2019
@SteveL-MSFT
Copy link
Member

@iSazonov I'll have her respond with more tracing info to figure out why it failed. Seems like it tried to query something from AzDevOps but in that state nothing got returned.

@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 22, 2019
@TravisEz13 TravisEz13 added CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log and removed CL-Untagged labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

0