8000 Add Obsolete message to Send-MailMessage by TravisEz13 · Pull Request #9178 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add Obsolete message to Send-MailMessage #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 7 commits into from
Mar 22, 2019
Merged

Add Obsolete message to Send-MailMessage #9178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a29e1ac
Add Obsolete message to Send-MailMessage
TravisEz13 Mar 20, 2019
3b4e3f8
try to test for warnings
TravisEz13 Mar 22, 2019
79547f8
Address PR Feedback
TravisEz13 Mar 22, 2019
ecdeea9
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Sen…
SteveL-MSFT Mar 22, 2019
f5cbd7b
Update Send-MailMessage.cs
TravisEz13 Mar 22, 2019
cc0f1e0
Update Send-MailMessage.cs
TravisEz13 Mar 22, 2019
6ac7c6d
Update src/Microsoft.PowerShell.Commands.Utility/commands/utility/Sen…
iSazonov Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ namespace Microsoft.PowerShell.Commands
/// <summary>
/// Implementation for the Send-MailMessage command.
/// </summary>
[Obsolete("This cmdlet does not guarantee secure connections to SMTP servers. While there is no immediate replacement available in PowerShell, we recommend you do not use Send-MailMessage at this time. See https://aka.ms/SendMailMessage for more information.")]
[Cmdlet(VerbsCommunications.Send, "MailMessage", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=135256")]
public sealed class SendMailMessage : PSCmdlet
{
Expand Down
11 changes: 10 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,16 @@ Describe "Send-MailMessage" -Tags CI, RequireSudoOnUnix {

$server | Should -Not -Be $null

Send-MailMessage @InputObject -ErrorAction SilentlyContinue
$powershell = [PowerShell]::Create()

$null = $powershell.AddCommand("Send-MailMessage").AddParameters($InputObject).AddParameter("ErrorAction","SilentlyContinue")

$powershell.Invoke()

$warnings = $powershell.Streams.Warning

$warnings.count | Should -BeGreaterThan 0
$warnings[0].ToString() | Should -BeLike "The command 'Send-MailMessage' is obsolete. *"

$mail = Read-Mail

Expand Down
0