Add Obsolete message to Send-MailMessage#9178
Merged
TravisEz13 merged 7 commits intoPowerShell:masterfrom Mar 22, 2019
Merged
Conversation
iSazonov
reviewed
Mar 21, 2019
| /// <summary> | ||
| /// Implementation for the Send-MailMessage command. | ||
| /// </summary> | ||
| [Obsolete("This cmdlet only supports sending mail from insecure SMTP servers. While there is no immediate replacement available in PowerShell, we recommend you do not use Send-MailMessage at this time.")] |
Collaborator
There was a problem hiding this comment.
"from"? Maybe "insecure connect to"?
adityapatwardhan
requested changes
Mar 21, 2019
| /// <summary> | ||
| /// Implementation for the Send-MailMessage command. | ||
| /// </summary> | ||
| [Obsolete("This cmdlet only supports sending mail from insecure SMTP servers. While there is no immediate replacement available in PowerShell, we recommend you do not use Send-MailMessage at this time.")] |
Member
There was a problem hiding this comment.
Please add test to validate.
Member
Author
There was a problem hiding this comment.
WarningVariables does not capture this warning.
Member
There was a problem hiding this comment.
Try using powershell.invoke and then check the streams.
Collaborator
There was a problem hiding this comment.
It would be nice to have a xUnit test suite for all public APIs to have API contract.
SteveL-MSFT
requested changes
Mar 21, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs
Outdated
Show resolved
Hide resolved
adityapatwardhan
approved these changes
10000
Mar 22, 2019
|
|
||
| $null = $powershell.AddCommand("Send-MailMessage").AddParameters($InputObject).AddParameter("ErrorAction","SilentlyContinue") | ||
|
|
||
| #Send-MailMessage @InputObject -ErrorAction SilentlyContinue |
…d-MailMessage.cs Co-Authored-By: TravisEz13 <travis.plunk@microsoft.com>
iSazonov
approved these changes
Mar 22, 2019
daxian-dbw
approved these changes
Mar 22, 2019
iSazonov
reviewed
Mar 22, 2019
src/Microsoft.PowerShell.Commands.Utility/commands/utility/Send-MailMessage.cs
Outdated
Show resolved
Hide resolved
…d-MailMessage.cs Co-Authored-By: TravisEz13 <travis.plunk@microsoft.com>
SteveL-MSFT
approved these changes
Mar 22, 2019
TravisEz13
added a commit
that referenced
this pull request
Mar 25, 2019
Add Obsolete message to Send-MailMessage ## PR Context See PowerShell/PowerShell-RFC#160 Co-authored-by: Steve Lee <slee@microsoft.com> Co-authored-by: Ilya <darpa@yandex.ru> # Conflicts: # test/powershell/Modules/Microsoft.PowerShell.Utility/Send-MailMessage.Tests.ps1
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add Obsolete message to Send-MailMessage
PR Context
See PowerShell/PowerShell-RFC#160
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests