8000 -Verbose should not override $ErrorActionPreference by SteveL-MSFT · Pull Request #5113 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

-Verbose should not override $ErrorActionPreference #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
Oct 26, 2017
Merged

-Verbose should not override $ErrorActionPreference #5113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45115ed
-Verbose should not override $ErrorActionPreference
SteveL-MSFT Oct 14, 2017
511e026
apply same fix to -debug and added test case
SteveL-MSFT Oct 17, 2017
3b4f78d
address Aditya's feedback
SteveL-MSFT Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/System.Management.Automation/engine/MshCommandRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3212,13 +3212,6 @@ internal ActionPreference ErrorAction
if (IsErrorActionSet)
return _errorAction;

// Debug takes preference over Verbose
if (Debug)
return ActionPreference.Inquire;
if (Verbose)
return ActionPreference.Continue;

// fall back to $ErrorAction
if (!_isErrorActionPreferenceCached)
{
bool defaultUsed = false;
Expand Down
19 changes: 19 additions & 0 deletions test/powershell/Language/Scripting/ActionPreference.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,23 @@
}
$num | Should Be 2
}

It '<switch> does not take precedence over $ErrorActionPreference' -TestCases @(
@{switch="-Verbose"},
@{switch="-Debug"}
) {
param($switch)
$ErrorActionPreference = "SilentlyContinue"
$params = @{
ItemType = "File";
Path = "$testdrive\test.txt";
Confirm = $false
}
New-Item @params > $null
$params += @{$switch=$true}
{ New-Item @params } | Should Not Throw
$ErrorActionPreference = "Stop"
{ New-Item @params } | ShouldBeErrorId "NewItemIOError,Microsoft.PowerShell.Commands.NewItemCommand"
Remove-Item "$testdrive\test.txt" -Force
}
}
0