8000 -Verbose should not override $ErrorActionPreference by SteveL-MSFT · Pull Request #5113 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

-Verbose should not override $ErrorActionPreference #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 3 commits into from
Oct 26, 2017
Merged

-Verbose should not override $ErrorActionPreference #5113

adityapatwardhan merged 3 commits into from
Oct 26, 2017

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Oct 14, 2017

Fix #2247

@SteveL-MSFT SteveL-MSFT added the Breaking-Change breaking change that may affect users label Oct 14, 2017
anmenaga
anmenaga suggested changes Oct 17, 2017
View reviewed changes
Copy link
@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is only for Verbose;
however, original issue says that it was approved for both: Verbose and Debug : "Committee agrees that we should fix this so that -ErrorAction works correctly and not overridden by -Debug or -Verbose".
Should this change be done for Debug as well?

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 17, 2017

@anmenaga that's a fair point about -Debug. I'll update this.

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 18, 2017

@anmenaga can you review again?

adityapatwardhan
adityapatwardhan requested changes Oct 18, 2017
View reviewed changes
test/powershell/Language/Scripting/ActionPreference.Tests.ps1 Outdated
Path = "$testdrive\test.txt";
Confirm = $false
}
New-Item @params
Copy link
Member
@adityapatwardhan adityapatwardhan Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> $null

Copy link
Member Author
@SteveL-MSFT SteveL-MSFT Oct 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Oct 18, 2017

@adityapatwardhan can you review again?

@adityapatwardhan adityapatwardhan merged commit b1af9ea into PowerShell:master Oct 26, 2017
@SteveL-MSFT SteveL-MSFT deleted the verbose-downgrade branch October 26, 2017 22:35
@mintsoft
Copy link
mintsoft commented Oct 28, 2017

Is this likely to make it into the final for Powershell 6?

@markekraus
Copy link
Contributor
markekraus commented Oct 28, 2017

@mintsoft This was merged to master so it will be in the release unless it needs to be reverted for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

@BrucePay BrucePay Awaiting requested review from BrucePay

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@lzybkr lzybkr Awaiting requested review from lzybkr

@vors vors Awaiting requested review from vors

+1 more reviewer

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

Breaking-Change breaking change that may affect users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SteveL-MSFT @mintsoft @markekraus @anmenaga @adityapatwardhan
0