files to build packages (and to build a real MMIN assembly on windows) #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI, the configurations can be used to conditionally add dependencies, which we could use to do Windows and Linux specific things. |
|
I've had some thoughts on this lately. We're going to end up with two versions of MMIN. The real one on Windows, and @zach-folwick's replacement for it on Linux. We will need to take a runtime specific dependency on two different projects (blocked by NuGet/Home#1660). It would turn into a three packages, the MMIN API referenced by the rest of the project, and it would reference the Linux and Windows versions, much the same way that .NET Core builds platform specific packages. |
|
I think we can safely close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the code to build Microsoft.Management.Infrastructure.Native assembly.
Also adds a script to build packages for all the projects.
This change is