beta.8 changelog draft #5006

TravisEz13 · 2017-10-04T19:26:40Z

No description provided.

SteveL-MSFT · 2017-10-04T19:37:36Z

CHANGELOG.md

@@ -1,5 +1,111 @@
 # Changelog

+## v6.0.0-beta.8 - 2017-10-05
+
+### Engine updates and fixes


We need to have the Breaking Changes on top: #4802, #4866, #4903, #4963

SteveL-MSFT · 2017-10-04T19:38:39Z

CHANGELOG.md

+
+* Make calls to void CodeMethod work (#4850) (Thanks @powercode)
+* Get 'PSVersion' and 'GitCommitId' from the 'ProductVersion' attribute of assembly (#4863) (Thanks @iSazonov)
+* Write an error and return an exit code for powershell -version 2 (#4931) (Thanks @iSazonov)


This code was essentially replaced by #4958, perhaps just combine them and attribute to Ilya

SteveL-MSFT · 2017-10-04T19:39:44Z

CHANGELOG.md

+* Fix importing remote module using version filters and added tests (#4900)
+* Enable transcription of native commands on non-Windows (#4871)
+* Fix `powershell -version` and help to align with other tools (#4958)
+* Fix incorrect position of a parameter which resulted in the args passed as input instead of as args (#4963)


Should call out this is for InvokeScript() api

SteveL-MSFT · 2017-10-04T19:41:28Z

CHANGELOG.md

+    * Exclude directories discovered from `-Path` (#4829) (Thanks @iSazonov)
+    * Support more argument completion scenarios by adding `ArgumentCompletionsAttribute` (#4835) (Thanks @iSazonov)
+* Exclude `-Comobject` parameter of `New-Object` on unsupported platforms (#4922) (Thanks @iSazonov)
+* Updated default `ModuleVersion` in `New-ModuleManifest` (#4842) (Thanks @LDSpits)


I think this should be:
Updated default ModuleVersion in New-ModuleManifest to 0.0.1 to align with SemVer

SteveL-MSFT · 2017-10-04T19:42:19Z

CHANGELOG.md

+
+### Documentation and Graphics
+
+* New icon for PowerShell Core (#4848)


This should be in the packaging section

SteveL-MSFT · 2017-10-04T19:43:03Z

CHANGELOG.md

+* Suppress the output of building test tools in Compress-TestContent (#4957)
+* Remove unnecessary error messages from output (#4954)
+* Update travis-ci script so that PRs can fail due to pester tests (#4830)
+* Revert the changes to Pester from merged PR #4184 (#4881)


Seems like this isn't worth mentioning as there's no user impact

SteveL-MSFT · 2017-10-04T19:44:07Z

CHANGELOG.md

+* Revert the changes to Pester from merged PR #4184 (#4881)
+* Move release build definition into PowerShell (#4884)
+* Fix credential scan issues (#4927)
+* Add line secret suppression (#4935)


Seems like we can combine this with #4927 above

SteveL-MSFT · 2017-10-04T19:45:11Z

CHANGELOG.md

+* Remove unsupported -showwindow switch (#4903)
+* Enable auto EOL on git repo side, fix some character encoding issues (#4912)
+* Autocorrected CRLF to LF (#4943)
+* Change CRLF to LF for files that are already in repository (#4956)


Combine with #4943. Just say: Updated EOL for all files to be LF in the repository.

SteveL-MSFT · 2017-10-04T19:45:53Z

CHANGELOG.md

+    * delay (#4905)
+    * gzip & enable deflate (#4948)
+    * related changes and fixes (#4920)
+* Fix for Linux platform PowerShell exit on error during SSH remoting connection (#4993)


This should go under Engine Updates

daxian-dbw · 2017-10-04T20:19:13Z

CHANGELOG.md

+* Added functionality to set credientials on `Set-Service` command (#4844) (Thanks @joandrsn)
+* `Select-String` changes:
+    * Exclude directories discovered from `-Path` (#4829) (Thanks @iSazonov)
+    * Support more argument completion scenarios by adding `ArgumentCompletionsAttribute` (#4835) (Thanks @iSazonov)


This change is for Get-Date, not select-string. see #4835

daxian-dbw · 2017-10-04T20:26:01Z

CHANGELOG.md

+
+### Breaking change
+
+* Changed `new-service` to return error when given unsupported startuptype and fixed set-service failing test (#4802)


It's better to use upper case for the first letter: New-Service.

daxian-dbw · 2017-10-04T20:26:09Z

CHANGELOG.md

+### Breaking change
+
+* Changed `new-service` to return error when given unsupported startuptype and fixed set-service failing test (#4802)
+* Allow * to be used in registry path for `remove-item` (#4866)


Same for Remove-Item

daxian-dbw · 2017-10-04T20:26:58Z

CHANGELOG.md

+
+* Changed `new-service` to return error when given unsupported startuptype and fixed set-service failing test (#4802)
+* Allow * to be used in registry path for `remove-item` (#4866)
+* Remove unsupported -showwindow switch (#4903)


Remove from where? And -showwindow should be in a code block.

daxian-dbw · 2017-10-04T20:27:54Z

CHANGELOG.md

+* Make calls to void CodeMethod work (#4850) (Thanks @powercode)
+* Get 'PSVersion' and 'GitCommitId' from the 'ProductVersion' attribute of assembly (#4863) (Thanks @iSazonov)
+* Fix `powershell -version` and help to align with other tools (#4958 & #4931) (Thanks @iSazonov)
+* Load the assembly with 'Assembly.LoadFrom' before 'Assembly.Load' when the file path is given (#4196)


Assembly.LoadFrom and Assembly.Load should be in code block I think.

daxian-dbw · 2017-10-04T20:30:06Z

CHANGELOG.md

+* Exclude `-Comobject` parameter of `New-Object` on unsupported platforms (#4922) (Thanks @iSazonov)
+* Updated default `ModuleVersion` in `New-ModuleManifest` to `0.0.1` to align with SemVer (#4842) (Thanks @LDSpits)
+* Add Multipart Support to Web Cmdlets (#4782) (Thanks @markekraus)
+* Initialize Web Cmdlets Headers Dictionary Only Once (#4853) (Thanks @markekraus)


Maybe we shouldn't use a capital letter for the first letter for "headers dictionary only once".

daxian-dbw · 2017-10-04T20:33:51Z

CHANGELOG.md

+
+* Sort .spelling  (Thanks @markekraus)
+* Improve the guideline for perf consideration (#4824)
+* Fix issues with expression redirected to file (#4847)


This is an engine fix

daxian-dbw · 2017-10-04T20:34:38Z

CHANGELOG.md

+
+### DSC Language
+
+* Update version of PSDesiredStateConfiguration in project files (#4979)


Maybe mention "to support compile configuration on windows"?

joeyaiello · 2017-10-05T00:01:13Z

Running for the bus, still need to do spelling. I'll do it tonight though. :)

iSazonov · 2017-10-05T04:42:15Z

I like to say "Thanks" for MSFT workers too.

markekraus · 2017-10-05T08:50:16Z

Hmm. I don't see #4888 listed. I assumed it would be in this release?

SteveL-MSFT · 2017-10-05T15:10:37Z

@markekraus yes, it should be in this release. @TravisEz13 can you check how you enumerated the commits?

joeyaiello · 2017-10-05T16:37:49Z

Nooo my push didn't push... :(

Unless I pushed it somewhere else...aaand interestingly enough, even the first commit in this branch doesn't show up in my contribution history. Time to do some forensics..

In any case, I've made the changes, just give me a few mins to get them up.

joeyaiello · 2017-10-05T16:39:35Z

Whelp, I used the VS Code commit thingy and my lack of muscle memory there made me forget to do the push. Nice....

daxian-dbw · 2017-10-05T16:46:28Z

CHANGELOG.md

+* Added functionality to set credentials on `Set-Service` command. (#4844) (Thanks @joandrsn)
+* `Select-String` changes:
+    * Exclude directories (as opposed to individual files) discovered from `-Path`. (#4829) (Thanks @iSazonov)
+    * Support more argument completion scenarios by adding `ArgumentCompletionsAttribute`. (#4835) (Thanks @iSazonov)


#4835 was to add argument completion support to Get-Date, not Select-String.

daxian-dbw · 2017-10-05T16:47:11Z

CHANGELOG.md

+
+* Sort `.spelling` (Thanks @markekraus)
+* Improve the guideline for perf consideration. (#4824)
+* Fix issues with expression redirected to file. (#4847)


This fix is an engine fix, not document/graphics related.

daxian-dbw

Good timing :) LGTM

markekraus · 2017-10-05T17:02:26Z

CHANGELOG.md

+* Add Multipart support to web cmdlets. (#4782) (Thanks @markekraus)
+* Add `-ResponseHeadersVariable` to `Invoke-RestMethod` to enable the capture of response headers. (#4888) (Thanks @markekraus) 
+* Initialize web cmdlets headers dictionary only once. (#4853) (Thanks @markekraus)
+* Change web cmdlets `UserAgent` from `WindowsPowerShell` to `PowerShell`. (#4914)


Not that I really care, but I'm not credited here for #4914

I think you should get credited, but for me this raises a more important issue we should address post beta.8 which is it seems the changelog draft should be autogenerated so that all the issue numbers and credit is pulled from GitHub. Script can scrub the MSFT contributions. Organizing and rewording will still be manual.

Adding the credit while I make some other fixes to spelling and lint errors

daxian-dbw · 2017-10-05T19:48:22Z

@joeyaiello The build still fails with a spelling error

SteveL-MSFT · 2017-10-05T20:26:10Z

@joeyaiello is at an offsite meeting, I'll fix the spelling errors

SteveL-MSFT · 2017-10-05T21:12:14Z

Can't figure out why it's failing the spell check. Trying something by putting CDXML in backticks

SteveL-MSFT · 2017-10-05T21:23:13Z

Running the markdown-spellcheck test locally passes. The error on Travis doesn't say what is wrong. I checked each word against the en-US dictionary the tool uses and every word on the sentence it shows with the issues passes except CDXML, but that was added to the dictionary. Strange.

SteveL-MSFT · 2017-10-05T23:06:58Z

Looks like I got it to pass the spell check by rewording that one line. I suspect is the offending word is timezone.

beta.8 changelog draft

8674e8c

TravisEz13 assigned daxian-dbw Oct 4, 2017

TravisEz13 requested review from joeyaiello and SteveL-MSFT October 4, 2017 19:26

SteveL-MSFT requested changes Oct 4, 2017

View reviewed changes

address PR feedback fros stevel-msft

1537ce1

SteveL-MSFT approved these changes Oct 4, 2017

View reviewed changes

Address part of the spelling issues

1ad0e31

daxian-dbw requested changes Oct 4, 2017

View reviewed changes

fix formatting/wording

6fa41ff

fix spelling for beta.8 changelog

dec415b

joeyaiello approved these changes Oct 5, 2017

View reviewed changes

daxian-dbw requested changes Oct 5, 2017

View reviewed changes

daxian-dbw approved these changes Oct 5, 2017

View reviewed changes

markekraus reviewed Oct 5, 2017

View reviewed changes

last round of fixes to beta.8 changelog

a73ef65

markekraus approved these changes Oct 5, 2017

View reviewed changes

put CDXML in backticks

8e0a494

SteveL-MSFT force-pushed the changelog-beta-8 branch 2 times, most recently from 12a703e to 25d9f63 Compare October 5, 2017 22:08

reword CDXML test line

009c06d

SteveL-MSFT force-pushed the changelog-beta-8 branch from 25d9f63 to 009c06d Compare October 5, 2017 22:43

daxian-dbw merged commit 277b811 into release Oct 5, 2017

daxian-dbw deleted the changelog-beta-8 branch October 5, 2017 23:43


		### Documentation and Graphics

		* New icon for PowerShell Core (#4848)


		### Breaking change

		* Changed `new-service` to return error when given unsupported startuptype and fixed set-service failing test (#4802)


		### DSC Language

		* Update version of PSDesiredStateConfiguration in project files (#4979)

beta.8 changelog draft #5006

beta.8 changelog draft #5006

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!