Fix credential scan issues #4927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Sep 27, 2017
| @@ -1,8 +1,9 @@ | |||
| Describe "ConvertTo-SecureString" -Tags "CI" { | |||
| Describe "ConvertTo--SecureString" -Tags "CI" { | |||
There was a problem hiding this comment.
Seems to have an extra - between ConvertTo and SecureString
There was a problem hiding this comment.
I have to rename it to something other than convertto-securestring.
|
|
||
| Context "Checking return types of ConvertTo-SecureString" { | ||
| Context "Checking return types of ConvertTo--SecureString" { |
There was a problem hiding this comment.
Seems to have an extra - between ConvertTo and SecureString
There was a problem hiding this comment.
See the previous comment
adityapatwardhan
approved these changes
Sep 27, 2017
Merged
|
Just out of curiosity, is the |
|
@megamorf It's specific to the tool we use. Unfortunately, the tool itself is internal to Microsoft only. That is why we run it in VSTS and not our normal CI systems. |
|
@TravisEz13 Ah, that makes sense. Thanks for the answer :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suppression for lines with secrets.
Add suppressions for files which are secrets.
This will be consumed in the VSTS daily build.
Renamed tests with
ConvertTo-SecureStringto avoid false positives