8000 Resx - remove trailing white spaces and extra Newline at EOF by iSazonov · Pull Request #4047 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Resx - remove trailing white spaces and extra Newline at EOF #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2017

Conversation

iSazonov
Copy link
Collaborator
  1. Commit - remove trailing white spaces

Motivation - So far we have not been able to use VS Code automatic removing trailing white spaces without the cleanup.

The cleanup is done with @lzybkr script from #3001

  1. Commit - remove extra Newline at EOF

A few days ago in #3576 I saw Resx files without Newline at EOF. Now they're miraculously gone. I don't know who and how to fix it. Now I only found files with extra Newline at EOF. Fixing script is based on script above and attached.

fix_EOF.txt

Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md with the recommended settings in VSCode for automatic removing of trailing whitespace for resx files

@lzybkr
Copy link
Contributor
lzybkr commented Jun 19, 2017

Just confirming - this PR does not leave files with no newlines at the EOF, right?
It just replaces 2 newlines with 1, or adds 1 if there was none, right?

@iSazonov
Copy link
Collaborator Author

Just confirming - this PR does not leave files with no newlines at the EOF, right?

Yes.

Just confirming - this PR does not leave files with no newlines at the EOF, right?

Yes. Actually only removes extra Newline at EOF. Resx files without Newline at EOF is not found.

@iSazonov
Copy link
Collaborator Author

@SteveL-MSFT
Copy link
Member

@iSazonov yeah, even better!

@iSazonov
Copy link
Collaborator Author
iSazonov commented Jun 20, 2017

@SteveL-MSFT I open #4054

Full description of VS Code is in using-vscode.md - so I added recommendations in the document and link from CONTRIBUTING.md

@lzybkr lzybkr merged commit aa97fe7 into PowerShell:master Jun 22, 2017
@iSazonov iSazonov deleted the resx-ws branch June 23, 2017 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0