Convert tab indentations to spaces in *.resx files #3576
Conversation
| @@ -143,7 +143,7 @@ | |||
| Windows PowerShell transcript start | |||
| Start time: {0:yyyyMMddHHmmss} | |||
| Username : {1}\{2} | |||
| Machine : {3} ({4}) | |||
| Machinen : {3} ({4}) | |||
There was a problem hiding this comment.
Machinen [](start = 0, length = 8)
extra 'n'?
| </root> |
| </root> |
| </root> |
| </root> |
There was a problem hiding this comment.
A guess: I think your script was fairly consistent with these. If it made a change in the file, it didn't add an extra newline at the end. I'm going to stop commenting on each individual one. Please make it consistent throughout if you are going to make this change.
|
@lzybkr - I remember that you had some thoughts on this topic so I wanted to make sure you are aware of this PR. |
|
Well, my thoughts are basically - style/formatting changes shouldn't be piecemeal - we should deal with all the files at once. And I'd prefer to see one commit per "kind" of change, say replace tabs, or fix file encoding, or add/remove newlines. The newline at the end is an annoying issue - some tools expect a newline on the last line (like So my point here is - unless we have a pre-commit hook, it's a battle we can't win. |
|
I prepared Add Metatests #3504 It cannot be activated until all the files are cleaned up. I believe we must first do the global file cleanup then activate the checks, first, for the current commits, then globally in the nightly tests. We have already done a few steps: In the PR I convert tab indentations in *.resx. And in the end I plan to add Newline at EOF in all files. I did not follow the rule "all the files at once" because @TravisEz13 asked to do a work in smaller chunks to simplify a review. Can we follow this roadmap? |
|
The risk of doing everything in one large change is that you won't be able to ever merge the change due to merge conflicts. |
|
Conflict was resolved. |
|
@mirichmo Could we continue with the PR? |
Prepare to pass meta test #3504.
First commit convert tab indentations to spaces in *.resx files.
Second commit add Newlines at EOF.