8000 Revert change to use `BinaryFormatter` for `Out-GridView` by SteveL-MSFT · Pull Request #20300 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Revert change to use BinaryFormatter for Out-GridView #20300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2023
Merged

Revert change to use BinaryFormatter for Out-GridView #20300

merged 2 commits into from
Sep 21, 2023

Conversation

SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Sep 19, 2023 •
edited by iSazonov
Loading

PR Summary

Revert #20050

Out-GridView was designed around using the BinaryFormatter to make deep copies of Filters. When we removed usage of that type, we inadvertently broke filtering (although contains filter still worked, but only that one). This change reverts the specific removal of use of BinaryFormatter for Out-GridView to bring back the previous functionality. The previous change to a Clone() method was removed as it was incomplete.

Manually tested each filter and duplicate filters.

PR Context

Fix #20223

PR Checklist

@iSazonov
Copy link
Collaborator

BinaryFormatter will removed from .Net 9.0 at all. So maybe revert only for release branch 7.4 and implement full fix for master branch?

@SteveL-MSFT
Copy link
Member Author

@iSazonov yes, we have more time with 7.5 to change the design to not rely on BinaryFormatter

daxian-dbw
daxian-dbw reviewed Sep 20, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Left 1 comment.

@pull-request-quantifier-deprecated
Copy link

This PR has 130 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +44 -86
Percentile : 46%

Total files changed: 29

Change summary by file extension:
.cs : +43 -86
.csproj : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit d2b3ff7 into PowerShell:master Sep 21, 2023
@iSazonov
Copy link
Collaborator

Have we a tracking issue for follow work?

daxian-dbw pushed a commit that referenced this pull request Sep 25, 2023
@SteveL-MSFT @daxian-dbw
Revert changes to continue using BinaryFormatter for Out-GridView (…
c92224f 
…#20300)
@daxian-dbw daxian-dbw mentioned this pull request Sep 25, 2023
Merged
daxian-dbw added a commit that referenced this pull request Sep 25, 2023
@daxian-dbw
[release/v7.4.0-preview.6] Revert changes to continue using `BinaryFo…
bcfdb27 
…rmatter` for `Out-GridView` (#20300) (#20360)
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be 9065 marked as a general cmdlet change in the Change Log label Jan 18, 2024
@iSazonov iSazonov mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@daxian-dbw daxian-dbw

Labels
BackPort-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Out-GridView filtering via criteria in 7.4.0-preview.5 yields incorrect results
3 participants
@SteveL-MSFT @iSazonov @daxian-dbw
0