8000 Fix Out-GridView by implementing `Clone()` method to replace old use of binary format serialization by SteveL-MSFT · Pull Request #20050 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix Out-GridView by implementing Clone() method to replace old use of binary format serialization #20050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix Out-GridView by implementing Clone() method to replace old use of binary format serialization #20050

merged 2 commits into from
Aug 1, 2023

Conversation

SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Jul 31, 2023 •
edited
Loading

PR Summary

The PR to move to .NET 8 preview.4 removed all use of the binary format serializer since it is no longer supported in .NET. This inadvertently broke Out-GridView which heavily depends on binary serialization to make copies of FilterRules. The fix here is to introduce a new Clone() method in the abstract base class and implement it for each of the derived FilterRules.

PR Context

Fix #20015

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from daxian-dbw July 31, 2023 18:35
@pull-request-quantifier-deprecated
Copy link

This PR has 84 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Small
Size       : +83 -1
Percentile : 33.6%

Total files changed: 21

Change summary by file extension:
.cs : +83 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

JamesWTruher
JamesWTruher reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator
@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have validation anywhere for this?

@SteveL-MSFT
Copy link
Member Author

@JamesWTruher no automation, so just some manual validation with filtering

daxian-dbw
daxian-dbw approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 85795c3 into PowerShell:master Aug 1, 2023
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 1, 2023
@SteveL-MSFT SteveL-MSFT deleted the ogv-clone branch August 2, 2023 19:11
@iSazonov iSazonov mentioned this pull request May 5, 2025
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher JamesWTruher left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@daxian-dbw daxian-dbw

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Out-GridView filtering doesn't work with 7.4.0-preview.4
3 participants
@SteveL-MSFT @daxian-dbw @JamesWTruher
0