8000 Block any preview vPack release by TravisEz13 · Pull Request #20243 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Block any preview vPack release #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Block any preview vPack release #20243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9012a9
Block any preview vPack release
TravisEz13 Sep 11, 2023
fb89781
Update tools/releaseBuild/azureDevOps/vpackRelease.yml
TravisEz13 Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/releaseBuild/azureDevOps/vpackRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ stages:
ReleaseTagVar: $(ReleaseTagVar)
CreateJson: yes
UseJson: no

- powershell: |
if($env:RELEASETAGVAR -match '-') {
throw "Don't release a preview build without coordinating with Windows Engineering Build Tools Team"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fail the release pipeline? It may be better to not fail the pipeline, but just make it a non-op?

Copy link
Member Author
@TravisEz13 TravisEz13 Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fail the pipeline where the action fails. Hiding failures leads to confusion.

}
displayName: Stop any preview release

- powershell: Write-Host "##vso[build.updatebuildnumber]$env:BUILD_SOURCEBRANCHNAME-$env:BUILD_SOURCEVERSION-$((get-date).ToString("yyyyMMddhhss"))"
displayName: Set Build Name for Non-PR
Expand Down
0