8000 Block any preview vPack release by TravisEz13 · Pull Request #20243 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Block any preview vPack release #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2023
Merged

Block any preview vPack release #20243

merged 2 commits into from
Oct 19, 2023

Conversation

TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Sep 11, 2023 •
edited
Loading

PR Summary

Block vPack release if it has a - in the release tag

PR Context

Windows does not want to consume Preview/RC vPacks and they don't effectively use semantic versioning.

PR Checklist

TravisEz13
TravisEz13 commented Sep 11, 2023
View reviewed changes
@pull-request-quantifier-deprecated
Copy link

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +4 -0
Percentile : 1.6%

Total files changed: 1

Change summary by file extension:
.yml : +4 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 19, 2023
daxian-dbw
daxian-dbw reviewed Sep 19, 2023
View reviewed changes
tools/releaseBuild/azureDevOps/vpackRelease.yml

- powershell: |
if($env:RELEASETAGVAR -match '-') {
throw "Don't release a preview build without coordinating with Windows Engineering Build Tools Team"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fail the release pipeline? It may be better to not fail the pipeline, but just make it a non-op?

Copy link
Member Author
@TravisEz13 TravisEz13 Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fail the pipeline where the action fails. Hiding failures leads to confusion.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 22, 2023
@TravisEz13 TravisEz13 marked this pull request as ready for review September 25, 2023 18:18
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 25, 2023
@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Sep 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Oct 2, 2023
@adityapatwardhan adityapatwardhan merged commit 8be582b into master Oct 19, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Oct 19, 2023
@microsoft-github-policy-service
Copy link
Contributor
microsoft-github-policy-service bot commented Oct 19, 2023 •
edited by unfurl-links bot
Loading

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://forms.office.com/r/P926k48jRJ

adityapatwardhan pushed a commit that referenced this pull request Oct 19, 2023
@TravisEz13 @adityapatwardhan
Block any preview vPack release (#20243)
fb9d107
@adityapatwardhan adityapatwardhan mentioned this pull request Oct 19, 2023
Merged
adityapatwardhan added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Block any preview vPack release (#20243) (#20526)
e6ee40c
@adityapatwardhan adityapatwardhan added BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed BackPort-7.4.x-Approved labels Oct 19, 2023
@daxian-dbw daxian-dbw deleted the TravisEz13-block-vpack-preview branch January 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TravisEz13 @daxian-dbw @adityapatwardhan @StevenBucher98
0