Make StringUtil classes static
#15671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
iSazonov
approved these changes
Jun 25, 2021
daxian-dbw
reviewed
Jun 28, 2021
| /// Simple string formatting helper. | ||
| /// </summary> | ||
| internal class StringUtil | ||
| internal static class StringUtil |
Member
There was a problem hiding this comment.
ScheduledJob module is not being built in the code base today, so please undo the change here.
Actually, we may need to think about remove the code that is not used today.
Collaborator
There was a problem hiding this comment.
:-) LocalAccounts/StringUtil.cs too.
Contributor
Author
There was a problem hiding this comment.
@daxian-dbw I guess work to remove uncompiled code is covered by #9960?
Collaborator
|
The code is not in compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #14483.