8000 Enable CA1052: Static holder types should be Static or NotInheritable by xtqqczze · Pull Request #14483 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable CA1052: Static holder types should be Static or NotInheritable #14483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Jan 8, 2021
Merged

Enable CA1052: Static holder types should be Static or NotInheritable #14483

iSazonov merged 2 commits into from
Jan 8, 2021
8000

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 22, 2020 •
edited
Loading

@ghost ghost assigned iSazonov Dec 22, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Dec 22, 2020

PowerShell-CI-windows failures tracked by #14420.

@xtqqczze xtqqczze closed this Dec 22, 2020
@xtqqczze xtqqczze reopened this Dec 22, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 23, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 23, 2020 17:57
@xtqqczze xtqqczze mentioned this pull request Dec 23, 2020
Closed
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 31, 2020
@ghost
Copy link
ghost commented Dec 31, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov merged commit 50fd950 into PowerShell:master Jan 8, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 8, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 8, 2021
@xtqqczze xtqqczze deleted the CA1052 branch May 10, 2021 14:02
@xtqqczze xtqqczze mentioned this pull request Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov
0