8000 Add winget release script by rjmholt · Pull Request #15050 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Add winget release script #15050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 16, 2021
Merged

Conversation

rjmholt
Copy link
Collaborator
@rjmholt rjmholt commented Mar 17, 2021

PR Summary

Adds a script to automatically generate winget release PRs, such as microsoft/winget-pkgs#8854.

PR Context

Eventually we should be able to use this PR in automation, using a PowerShell GitHub account.

PR Checklist

$FromRepository = 'rjmholt',

[Parameter()]
[string]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this mandatory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run it yourself with PowerShellForGitHub and don't provide a token, it will use its locally stored token

@ghost ghost added the Review - Needed The PR is being reviewed label Mar 24, 2021
@ghost
Copy link
ghost commented Mar 24, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member

@rjmholt do you also want to make changes to the release pipline in this PR too?

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 1, 2021
@rjmholt
Copy link
Collaborator Author
rjmholt commented Apr 2, 2021

@rjmholt do you also want to make changes to the release pipline in this PR too?

I'd prefer to do that in a separate PR, since that will require more work and time to test properly

@rjmholt
Copy link
Collaborator Author
rjmholt commented Apr 15, 2021

@adityapatwardhan I believe this is ready to merge

@rjmholt
Copy link
Collaborator Author
rjmholt commented Apr 15, 2021

@adityapatwardhan scratch that, it looks like there's something to fix still

@rjmholt rjmholt marked this pull request as draft April 15, 2021 02:09
@rjmholt rjmholt marked this pull request as ready for review April 15, 2021 03:01
@rjmholt
Copy link
Collaborator Author
rjmholt commented Apr 15, 2021

Ok fixed. This is ready again now. See microsoft/winget-pkgs#10754 for an example PR

@rjmholt
Copy link
Collaborator Author
rjmholt commented Apr 15, 2021

Those markdown link checks are failing again. We should really kick those tests out to only run them on nightlies or something.

@adityapatwardhan adityapatwardhan merged commit 80f685f into PowerShell:master Apr 16, 2021
@adityapatwardhan adityapatwardhan added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Apr 16, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.6 milestone Apr 16, 2021
@rjmholt rjmholt deleted the winget-release branch April 16, 2021 22:19
rkeithhill pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@ghost
Copy link
ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0