8000 Add documentation comments section to coding guidelines by xtqqczze · Pull Request #14316 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Add documentation comments section to coding guidelines #14316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send yo 8000 u account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 4, 2020
  • Add new documentation comments section
  • Retarget doc comments link to conceptual article

Follow-up to #14314.

* Add new documentation comments section
* Retarget doc comments link to conceptual article
@ghost ghost assigned adityapatwardhan Dec 4, 2020
@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Dec 5, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 14, 2020
@ghost
Copy link
ghost commented Dec 14, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Co-authored-by: Ilya <darpa@yandex.ru>
@adityapatwardhan
Copy link
Member

I will merge this after the CI finishes,

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 19, 2021
@xtqqczze
Copy link
Contributor Author

@adityapatwardhan You could merge now.

PowerShell-CI-static-analysis failures are unrelated (markdown-link failures).

@adityapatwardhan adityapatwardhan merged commit 1b952a0 into PowerShell:master Apr 20, 2021
@adityapatwardhan
Copy link
Member

@xtqqczze Thank you for your contribution!

@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.6 milestone Apr 20, 2021
@xtqqczze xtqqczze deleted the codingguidelines-doccomments branch April 20, 2021 17:29
rkeithhill pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@ghost
Copy link
ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0