8000 Update dead link in Code Guidelines by iSazonov · Pull Request #14314 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Update dead link in Code Guidelines #14314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for Git 8000 Hub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Dec 4, 2020

PR Summary

Fix #14313.
Update dead link in Code Guidelines to pass CIs.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Dec 4, 2020
@ghost ghost assigned daxian-dbw Dec 4, 2020
@@ -86,7 +86,7 @@ We also run the [.NET code formatter tool](https://github.com/dotnet/codeformatt

* Make sure the added/updated comments are meaningful, accurate and easy to understand.

* Public members must use [doc comments](https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments).
* Public members must use [doc comments](https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Public members must use [doc comments](https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/).
* Public members must use [doc comments](https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@daxian-dbw daxian-dbw merged commit 927d20a into PowerShell:master Dec 4, 2020
@iSazonov iSazonov deleted the fix-doc-link-codeguidelines branch December 4, 2020 06:47
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 4, 2020
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken xmldoc link
3 participants
0