10BC0 support PUT with empty body parameter by pnepywoda · Pull Request #322 · OpenFeign/feign · GitHub
[go: up one dir, main page]
Skip to content

support PUT with empty body parameter#322

Merged
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
pnepywoda:empty-body
Jan 26, 2016
Merged

support PUT with empty body parameter#322
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
pnepywoda:empty-body

Conversation

@pnepywoda
Copy link
@pnepywoda pnepywoda commented Jan 26, 2016

follow-up commit to #271

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2016

NetflixOSS » feign » feign-pull-requests #201 SUCCESS
This pull request looks good

codefromthecrypt
codefromthecrypt reviewed Jan 26, 2016
View reviewed changes
CHANGELOG.md Outdated
Copy link
Contributor
@codefromthecrypt codefromthecrypt Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.14 has left the building! 8.15 :)

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jan 26, 2016

PUT with no content is semantically weird, but yeah understood.

LGTM after filing into 8.15 in the changelog

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2016

NetflixOSS » feign » feign-pull-requests #202 SUCCESS
This pull request looks good

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jan 26, 2016

@pnepywoda mind squashing into one commit? easier for me to click merge vs cherry-pick and squash on my end

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2016

NetflixOSS » feign » feign-pull-requests #203 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Jan 26, 2016
@adriancole
Merge pull request #322 from pnepywoda/empty-body
5281e62 
support PUT with empty body parameter
@codefromthecrypt codefromthecrypt merged commit 5281e62 into OpenFeign:master Jan 26, 2016
@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jan 26, 2016

thx! let me know if a release is urgent

@pnepywoda
Copy link
Author
pnepywoda commented Jan 26, 2016

We are waiting on this to get released...if it could happen this week it
would be great!

On Tue, Jan 26, 2016 at 2:15 AM, Adrian Cole notifications@github.com
wrote:

thx! let me know if a release is urgent

—
Reply to this email directly or view it on GitHub
#322 (comment).

@pnepywoda pnepywoda deleted the empty-body branch January 26, 2016 10:52
@pnepywoda
Copy link
Author
pnepywoda commented Jan 26, 2016

@adriancole actually it's become urgent on our end. Any possibility of release soon?

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jan 27, 2016 via email

@spencergibb
Copy link
Contributor
spencergibb commented Jan 27, 2016

I'd be happy to be the backup, though I haven't returned from surgery leave yet.

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jan 27, 2016 via email

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jan 27, 2016 via email

@kdavisk6 kdavisk6 mentioned this pull request Apr 2, 2018
Closed
velo pushed a commit that referenced this pull request Oct 8, 2024
@adriancole
Merge pull request #322 from pnepywoda/empty-body
a516cbc 
support PUT with empty body parameter
Sign up for free to join this conversation on GitHub. Alre 60B9 ady have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pnepywoda @cloudbees-pull-request-builder @codefromthecrypt @spencergibb
0