send empty response body for POST when no body parameter present#271
send empty response body for POST when no body parameter present#271pnepywoda wants to merge 3 commits intoOpenFeign:masterfrom
Conversation
|
NetflixOSS » feign » feign-pull-requests #148 SUCCESS |
core/src/main/java/feign/ReflectiveFeign.java
8000
Outdated
There was a problem hiding this comment.
What happens with other clients? Will this work?
There was a problem hiding this comment.
What other clients? You mean ones that don't use ReflectiveFeign? We only use the JAXRSContract so that's the targeted fix that I made here. I didn't test out other contracts.
There was a problem hiding this comment.
I mean non-OkHttpClient, such as ribbon or apache http client.
There was a problem hiding this comment.
Oh good point. My followup commit should fix it to only write an empty body for okhttp
|
NetflixOSS » feign » feign-pull-requests #149 SUCCESS |
|
👍 cool, thanks! |
|
Looks safe. Few things; one is a nit.
Otherwise, LGTM! |
|
ping! I'd like to cut a release today, so if you're ready, you can be in it! |
|
NetflixOSS » feign » feign-pull-requests #150 FAILURE |
|
Huh this is strange, it says there's a conflict in CHANGELOG.md but I can't figure out why or what the merge conflict actually is. @adriancole any ideas? |
|
you're behind upstream.. no big deal, I can rebase this on the way in. Thanks! |
|
in 8.10.0! |
|
Awesome stuff, thanks Adrian & Paul! |
follow-up commit to OpenFeign#271
follow-up commit to OpenFeign#271
follow-up commit to #271
see
http://johnfeng.github.io/blog/2015/06/30/okhttp-updates-post-wouldnt-be-allowed-to-have-null-body/