10000 feat(css): Add HSL/HSLA support by bundyo · Pull Request #7730 · NativeScript/NativeScript · GitHub
[go: up one dir, main page]
Skip to content

feat(css): Add HSL/HSLA support #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 13, 2019
Merged

feat(css): Add HSL/HSLA support #7730

merged 10 commits into from
Sep 13, 2019

Conversation

bundyo
Copy link
Contributor
@bundyo bundyo commented Aug 25, 2019 •
edited
Loading

PR Checklist

What is the current behavior?

There is no HSL/HSLA support

What is the new behavior?

HSL/HSLA colors work, like this:

ActionBar {
    background-color: hsla(50, 50%, 50%, .8);
}

Fixes/Implements/Closes #7729.

No breaking changes.

@cla-bot cla-bot bot added the cla: yes label Aug 25, 2019
@bundyo bundyo self-assigned this Aug 25, 2019
@bundyo bundyo mentioned this pull request Aug 25, 2019
Closed
m-abs
m-abs reviewed Aug 25, 2019
View reviewed changes
Copy link
Contributor
@m-abs m-abs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to review (I'm just a contributor), since it was a my issue for nativescript-theme-core that triggered this :)

LGTM. I had a few minor comments, and I think you should add some tests for hsl/hsla to unit-tests/css/parser.ts

@bundyo
Copy link
Contributor Author
bundyo commented Aug 26, 2019

Added two tests (as there are only two for every color space). 🙂

@bundyo bundyo mentioned this pull request Aug 26, 2019
Open
45 tasks
@ADjenkov ADjenkov self-requested a review September 10, 2019 10:48
@manoldonev manoldonev merged commit 3cabdde into master Sep 13, 2019
@manoldonev manoldonev deleted the bundev/hsla-support branch September 13, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanaelA NathanaelA NathanaelA left review comments

@m-abs m-abs m-abs left review comments

@manoldonev manoldonev manoldonev approved these changes

@ADjenkov ADjenkov ADjenkov approved these changes

Assignees

@bundyo bundyo

Labels
cla: yes css feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HSL/HSLA CSS color support
5 participants
@bundyo @NathanaelA @m-abs @manoldonev @ADjenkov
0