-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(css): Add HSL/HSLA support #7730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to review (I'm just a contributor), since it was a my issue for nativescript-theme-core
that triggered this :)
LGTM. I had a few minor comments, and I think you should add some tests for hsl/hsla to unit-tests/css/parser.ts
chore: Add tests
Added two tests (as there are only two for every color space). 🙂 |
…cript into bundev/hsla-support
PR Checklist
What is the current behavior?
There is no HSL/HSLA support
What is the new behavior?
HSL/HSLA colors work, like this:
Fixes/Implements/Closes #7729.
No breaking changes.