8000 Exclude libraries from auditwheel by SimonRit · Pull Request #266 · InsightSoftwareConsortium/ITKPythonPackage · GitHub
[go: up one dir, main page]
Skip to content

Exclude libraries from auditwheel#266

Merged
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
SimonRit:WheelExclude
Feb 16, 2024
Merged

Exclude libraries from auditwheel#266
dzenanz merged 2 commits intoInsightSoftwareConsortium:masterfrom
SimonRit:WheelExclude

Conversation

@SimonRit
Copy link
@SimonRit SimonRit commented Feb 14, 2024

This PR

- srit@srit-Precision-5480:~/tmp$ unzip LinuxWheel310-cuda116.zip 
Archive:  ../LinuxWheel310-cuda116.zip
  inflating: itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl  
  inflating: itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_28_x86_64.whl  
srit@srit-Precision-5480:~/tmp$ unzip itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Archive:  itk_cudacommon_cuda116-1.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
   creating: itk/
   creating: itk_cudacommon_cuda116-1.0.1.dist-info/
   creating: itk_cudacommon_cuda116.libs/
   creating: itk/Configuration/
  inflating: itk/CudaCommonPython.py  
  inflating: itk/_CudaCommonPython.so  
  inflating: itk/itkCudaDataManagerPython.py  
  inflating: itk/itkCudaImageDataManagerPython.py  
  inflating: itk/itkCudaImagePython.py  
  inflating: itk/itkImageSourceCudaCommonPython.py  
  inflating: itk/itkImageToImageFilterCudaCommonPython.py  
  inflating: itk/Configuration/CudaCommonConfig.py  
  inflating: itk/Configuration/CudaCommon_snake_case.py  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/LICENSE  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/METADATA  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/WHEEL  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/top_level.txt  
  inflating: itk_cudacommon_cuda116-1.0.1.dist-info/RECORD  
  inflating: itk_cudacommon_cuda116.libs/libtbb-b694c9f9.so.12.9
  • includes in the docker LD_LIBRARY_PATH the library paths to forward it to auditwheel.

BUG: Fix deprecated use of auditwheel policies with exlcude option
4a2188a 
cf8c3f3 introduced an option to exclude
libraries from the wheel using auditwheel lib_whitelist policy. This is
deprecated since
pypa/auditwheel@4886850. This patch
uses the --exclude option instead, see
pypa/auditwheel@0a2fdd1.
@SimonRit SimonRit mentioned this pull request Feb 14, 2024
Closed
@SimonRit
Copy link
Author
SimonRit commented Feb 14, 2024

cc @LucasGandel

dzenanz
dzenanz approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member
@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great fix.

@dzenanz dzenanz requested a review from thewtex February 14, 2024 19:50
thewtex
thewtex approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member
@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonRit thanks!

LGTM

@LucasGandel please take a look

dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 15, 2024
@dzenanz
WIP: Fix Linux Python packages
98f373e 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 15, 2024
@dzenanz
WIP: Fix Linux Python packages
369b9b5 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
@LucasGandel
Copy link
Collaborator
LucasGandel commented Feb 16, 2024

The change to use the new --exclude option looks good, thanks a lot!
I can't tell for the LD_LIBRARY_PATH change though.

@SimonRit
Copy link
Author
SimonRit commented Feb 16, 2024

I can't tell for the LD_LIBRARY_PATH change though.

I made it because auditwheel could not find the shared libraries otherwise. Maybe it was working before thanks to the whitelist? I honestly don't know why...

@dzenanz dzenanz merged commit 8b047b0 into InsightSoftwareConsortium:master Feb 16, 2024
@dzenanz
Copy link
Member
dzenanz commented Feb 16, 2024

How does this change in light of this PR being merged? I tried using it here, without much luck.

@SimonRit
Copy link
Author
SimonRit commented Feb 16, 2024

without much luck.

The error message in the failing build seems unrelated
Could NOT find SWIG (missing: SWIG_DIR)
I'm not sure what's the problem here...

@SimonRit SimonRit deleted the WheelExclude branch February 16, 2024 16:04
@dzenanz
Copy link
Member
dzenanz commented Feb 16, 2024

Maybe it is related to 96e3477?

dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 16, 2024
@dzenanz
WIP: Fix Linux Python packages
14d70e7 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 16, 2024
@dzenanz
WIP: Fix Linux Python packages
a78181d 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 16, 2024
@dzenanz
WIP: Fix Linux Python packages
2e72768 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 16, 2024
@dzenanz
WIP: Fix Linux Python packages
ebf97cd 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
dzenanz added a commit to dzenanz/ANTsWasm that referenced this pull request Feb 16, 2024
@dzenanz
WIP: Fix Linux Python packages
aee33ed 
Fix introduced by:
InsightSoftwareConsortium/ITKPythonPackage#266
@SimonRit
Copy link
Author
SimonRit commented Feb 16, 2024

Maybe it is related to 96e3477?

Possibly but I could not figure out why the CudaCommon CI had a different cmake command line, with the new options of this commit and not the former one as yours.

@dzenanz dzenanz mentioned this pull request Feb 16, 2024
Closed
@thewtex thewtex mentioned this pull request Mar 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@LucasGandel LucasGandel LucasGandel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SimonRit @LucasGandel @dzenanz @thewtex
0