Fix libraries in linux module wheels#265
Closed
SimonRit wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
Closed
Fix libraries in linux module wheels#265SimonRit wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
SimonRit wants to merge 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
added 2 commits
February 13, 2024 22:23
cf8c3f3 introduced an option to exclude libraries from the wheel using auditwheel lib_whitelist policy. This patch adapts ITKPythonPackage code to the new management of policies by auditwheel since pypa/auditwheel@4886850
Author
|
Actually |
Author
|
Superseded by #266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to fix #263. The second commit inform auditwheel on where are the wheels libraries. However, it does not seem to work so far, see the wheels produced by https://github.com/RTKConsortium/ITKCudaCommon/actions/runs/7901454685 which contain renamed versions of libcuda.so and libcudart.so, e.g.:
I'll keep trying but maybe the whitelist strategy in auditwheel does not work anymore? Or I missed something? cc @LucasGandel