test: generated libraries #1407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. only trigger format at generate-all.sh
|
Currently generates 89/89 libraries |
|
Merging #1392 allowed to |
|
Different error for |
|
Different error for TetherSpringAutoconf:149:
|
This RPC was just added two days ago, so it's not released yet. We should probably change our generation scripts to only look at the released commitish instead of head. |
This is also a bidi streaming methods, looks like we don't generate retry settings for all streaming methods? |
|
Kudos, SonarCloud Quality Gate passed!
|
I may have missed calling |
@blakeli0 thanks, you are right. |
I've double checked the commit we picked up in library_list.txt (758f0d1), it was brought in to 'google-cloud-java' on Dec 7 before the release v1.1.0 (Dec.09). |
zhumin8
reviewed
Dec 27, 2022
| fi | ||
|
|
||
| cd googleapis | ||
| git reset --hard $googleapis_comittish |
There was a problem hiding this comment.
Ah-ha! I think the issue you are observing with contact-center-insights is here:
you got a typo/mismatch between here and L22 and the commit hash was never used.
btw, why not git checkout <commit> here?
There was a problem hiding this comment.
Oh, I missed this comment! This may fix it. I will test and let you know.
I used git reset because for each library generate-one makes modifications to files in the repo, including some overlaps that would be modified multiple times. A git reset ended up being a straightforward workaround.
Thanks @zhumin8 !
| echo "Client Library ArtifactId: $client_lib_artifactid"; | ||
| echo "Parent Pom Version: $parent_version"; | ||
| echo "Googleapis Folder: $googleapis_folder"; | ||
| echo "Googleapis Commitish: $googleapis_comittish"; |
There was a problem hiding this comment.
typo/name mismatch
Suggested change
| echo "Googleapis Commitish: $googleapis_comittish"; | |
| echo "Googleapis Commitish: $googleapis_commitish"; |
|
I'm getting a startup error on a test spring application that uses NOTE: the language autoconf has |
zhumin8
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jan 4, 2023
Add name to `@ConditionalOnMissingBean` annotation when creating `TransportChannelProvider` bean so that it can be picked up with Qualifier in serviceSettings bean creation that follows. This was missed in original [commit](0643085) adding this bean and should fix error seen in GoogleCloudPlatform/spring-cloud-gcp#1407 (comment)
diegomarquezp
added a commit
that referenced
this pull request
Jan 4, 2023
|
Closing as #1422 will be used to breakdown each change |
diegomarquezp
added a commit
that referenced
this pull request
Jan 7, 2023
The source of changes was moved to #1422 for which several PRs were made and are now either closed or merged (#1430, #1428, #1427, #1426, #1425 , #1424). #1423 has not been merged as gapic-generator-java/1212 will invalidate this fix The found (and fixed) errors were: * the call to `xmllint` did not handle an empty `<modules>` list, causing the module addition function to fail in `generate-one` * missing `OPTARG` key `-x`, for commitish in `generate-one`
emmileaf
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jan 10, 2023
* This PR is a patch for the RetrySettings configuration issue discovered in GoogleCloudPlatform/spring-cloud-gcp#1407. It excludes streaming and LRO methods from retry configuration through spring properties for now.
diegomarquezp
added a commit
that referenced
this pull request
Jan 13, 2023
* fix: after merging breakdown of #1407 The source of changes was moved to #1422 for which several PRs were made and are now either closed or merged (#1430, #1428, #1427, #1426, #1425 , #1424). #1423 has not been merged as gapic-generator-java/1212 will invalidate this fix The found (and fixed) errors were: * the call to `xmllint` did not handle an empty `<modules>` list, causing the module addition function to fail in `generate-one` * missing `OPTARG` key `-x`, for commitish in `generate-one` * chore: undo unnecessary whitespace removal * fix: add module to pom - remove comment in pom and redundant folder spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges and adapts changes from:
So far:
Uses comittish from generated library list. Using the commitish in googleapis brings bazel errors about outdated rules/macros (1, 2). I've had to manually addsedcalls to remove some rules. Still working on sanitizing theWORKSPACEandBUILDfiles in googleapisBazel version must be 4.2.2