Module name changes structure change #1394
Conversation
…d. only trigger format at generate-all.sh
…ring-cloud-previews/pom to spring-cloud-gcp/pom profile.
This is part 2 of implementation for repo structural changes in [PoC](GoogleCloudPlatform/spring-cloud-gcp#1383). Changes in Pom string: - changed parent to `spring-cloud-gcp-starters` and version with "-preview" suffix - removed client library version (should inherit from Libraries BOM). Corresponding changes in spring-cloud-gcp: GoogleCloudPlatform/spring-cloud-gcp#1394
There was a problem hiding this comment.
One additional note that doesn't have to be a part of this PR: given the folder name changes, we should also update the github actions IT suppression from earlier (cc/ @diegomarquezp):
spring-cloud-gcp/.github/workflows/integrationTests.yaml
Lines 10 to 11 in c636695
| @@ -73,40 +73,46 @@ bazel build //$googleapis_folder:"$client_lib_name"_java_gapic_spring | |||
| cd - | |||
|
|
|||
| ## copy spring code to outside | |||
| mkdir -p ../generated | |||
| cp googleapis/bazel-bin/$googleapis_folder/"$client_lib_name"_java_gapic_spring-spring.srcjar ../generated | |||
| mkdir -p ../spring-cloud-previews | |||
There was a problem hiding this comment.
Nit: could we maybe use an exit code to condition these post-process / add to pom steps on the success status of the bazel build call above?
There was a problem hiding this comment.
Added exit on error option to address this for now (commit).
I will keep track of a separate task to improve error handling overall.
|
Kudos, SonarCloud Quality Gate passed!
|
- Integration tests: update path to ignore affected by change in #1394 (review) - Sonar: also disable sonar workflow for generated modules.
This folder/file is not needed anymore. it must have fall through the cracks and missed in #1394.
This folder/file is not needed anymore. it must have fall through the cracks and missed in #1394.
This is part 1 of implementation for #1383.
Changes include:
generate-one.shchange to add generated module tospring-cloud-gcp-startersspring-cloud-previewsfolder.fmt-maven-pluginto spring-cloud-gcp/pom with default set to skip.spring-cloud-gcp-dependenciesversion inheritance issue.spring-cloud-gcp-starters/pom.xmlformat change: replaced tabs with whitespaces, added comment marker for inserting generated modules.Changes that needs to happen on the generator side:
spring-cloud-gcp-startersas parent.previewsuffix to generated module versions.