Add test for iterRecords new start and stop args; ensure same Records…

… returned as from Reader.record
GeospatialPython · JamesParrott · Oct 18, 2024 · Oct 11, 2024 · Oct 15, 2024 · Oct 15, 2024
commit cc82ec82c4c14dda4b6bb802b46633504dc3ed15
diff --git a/test_shapefile.py b/test_shapefile.py
@@ -3,6 +3,7 @@
 """
 
 import datetime
+import itertools
 import json
 import os.path
 
@@ -968,10 +969,33 @@ def test_record_oid():
         for i, record in enumerate(sf.iterRecords()):
             assert record.oid == i
 
+
         for i, shaperec in enumerate(sf.iterShapeRecords()):
             assert shaperec.record.oid == i
 
 
+def test_iterRecords_start_stop():
+    """
+    Assert that Reader.iterRecords(start, stop)
+    returns the correct records, as if searched for
+    by Reader..
+    """
+
+
+    with shapefile.Reader("shapefiles/blockgroups") as sf:
+
+        N = len(sf)
+
+        # Arbitrary selection of start values
+        for start in [0, 1, 2, 3, 5, 11, 17, 33, 51, 103, 170, 234, 435, 543, N-3, N-2, N-1]:
+            for stop in range(start, len(sf)):
+                # test negative indexing from end, as well as
+                # positive values of stop, and its default
+                for stop_arg in (stop, stop - len(sf), None):
+                    for record in sf.iterRecords(start = start, stop = stop):
+                        assert record == sf.record(record.oid)
+
+
 def test_shape_oid():
     """
     Assert that the shape's oid attribute returns