8000 Combine iter records range into iter records by JamesParrott · Pull Request #310 · GeospatialPython/pyshp · GitHub
[go: up one dir, main page]
Skip to content

Combine iter records range into iter records #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 18, 2024
Merged

Combine iter records range into iter records #310

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e41b03c
Add option `my_range` to method iterRecords
lguez Oct 11, 2024
4efef9f
Revert "Add option `my_range` to method iterRecords"
lguez Oct 15, 2024
811d329
Add method `iterRecords_range`
lguez Oct 15, 2024
a6c739a
Combine the methods, giving start and stop default values. Remove f.…
JamesParrott Oct 17, 2024
0fdcab1
Add _Record.__eq__
JamesParrott Oct 17, 2024
74cf6dd
Let Ruff adjust code style (lead with ands, instead of trailing).
JamesParrott Oct 17, 2024
cc82ec8
Add test for iterRecords new start and stop args; ensure same Records…
JamesParrott Oct 17, 2024
3f5641b
Let Ruff reformat the list.
JamesParrott Oct 17, 2024
25a3199
Test default values. Pass in correct stop value.
JamesParrott Oct 17, 2024
4cead93
Relax _Record.__eq__ - don't require equal oids (PyShp implementation…
JamesParrott Oct 17, 2024
d4b3ed1
Add a blank line to appease Ruff.
JamesParrott Oct 17, 2024
6584f91
Remove unused import
JamesParrott Oct 17, 2024
7cb0889
Edit docstring
JamesParrott Oct 17, 2024
af94c7d
Update README.md
JamesParrott Oct 18, 2024
763bd33
Update README.md
JamesParrott Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Let Ruff adjust code style (lead with ands, instead of trailing).
  • Loading branch information
@JamesParrott
JamesParrott committed Oct 17, 2024
commit 74cf6dd96ef7c7d1fb4b64b14318eef03342ddc4
16 changes: 7 additions & 9 deletions shapefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,15 +855,13 @@ def __dir__(self):
return default + fnames

def __eq__(self, other):
return (isinstance(other, self.__class__) and
self.__field_positions == other.__field_positions and
self.oid == other.oid and
len(self) == len(other) and
all(val_self == val_other
for val_self, val_other in izip(self, other)
)
)

return (
isinstance(other, self.__class__)
and self.__field_positions == other.__field_positions
and self.oid == other.oid
and len(self) == len(other)
and all(val_self == val_other for val_self, val_other in izip(self, other))
)


class ShapeRecord(object):
Expand Down
0