[Part 3d] Pass policyTags to computeChatThreadReportName in ReportNameUtils#83930
Conversation
Keep ReportNameUtils backward compatible while enabling the temporary modified-expense formatter when policy tags are available, and add unit coverage for the tagged thread-name flow. Made-with: Cursor
Address the no-unused-vars lint error introduced by the temporary policyTags parameter and keep the extraction branch passing repository lint/prettier checks. Made-with: Cursor
Pass the required currentUserLogin argument to getForReportActionTemp so the extraction branch passes repository typecheck, lint, and prettier checks. Made-with: Cursor
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/libs/ReportNameUtils.ts
Outdated
| report: Report | undefined, | ||
| reportPolicy: Policy | undefined, | ||
| parentReport: Report | undefined, | ||
| policyTags?: OnyxEntry<PolicyTagLists>, |
There was a problem hiding this comment.
❌ CONSISTENCY-4
The policyTags parameter is added to computeReportNameBasedOnReportAction but is never used within the function body. It only appears in the redundant guard check if (policyTags && !parentReportAction), which is itself unnecessary (see related comment). The parameter is not passed to any downstream call, nor is it used for computation.
If this parameter is intended for a future PR in the migration series, consider adding it in the PR that actually uses it. Otherwise, remove it:
function computeReportNameBasedOnReportAction(
translate: LocalizedTranslate,
parentReportAction: ReportAction | undefined,
report: Report | undefined,
reportPolicy: Policy | undefined,
parentReport: Report | undefined,
- policyTags?: OnyxEntry<PolicyTagLists>,
): string | undefined {Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| movedFromReport, | ||
| movedToReport, | ||
| policyTags, | ||
| currentUserLogin: '', |
There was a problem hiding this comment.
❌ CONSISTENCY-2
The hardcoded empty string currentUserLogin: '' is used as a sentinel value to intentionally trigger the fallback logic in getForReportActionTemp (which falls back to storedCurrentUserLogin when the parameter is falsy). This is a non-obvious magic value — readers have to understand the fallback mechanism in getForReportActionTemp to know why an empty string is being passed.
Consider making currentUserLogin optional in getForReportActionTemp's signature (since the migration is incremental and the fallback already exists), or pass the actual current user login value. If the intent is to rely on the stored value, omitting the parameter (with an optional type) would be clearer than passing an empty string sentinel.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9540aa93d1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| movedToReport, | ||
| }); | ||
| const modifiedMessage = policyTags | ||
| ? getForReportActionTemp({ |
There was a problem hiding this comment.
When policyTags is present this branch switches to getForReportActionTemp, but the call omits policy. In that helper, MCC-driven category edits check isPolicyAdmin(policy, currentUserLogin) before adding the workspace-rules link, so an undefined policy forces the non-admin message path. This means modified-expense thread names can lose admin-specific MCC context whenever policyTags is supplied and the edit includes a category change sourced from MCC.
Useful? React with 👍 / 👎.
The parameter is reserved for the upcoming caller-propagation step and intentionally unused yet. Replace the redundant early-return guard with an explicit eslint-disable comment to make that intent clear. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…ion and pass policy through computeChatThreadReportName - Remove _policyTags from computeReportNameBasedOnReportAction; the function handles SUBMITTED/HOLD/IOU actions, none of which use policy tags. The modified-expense path lives entirely in computeChatThreadReportName. - Add policy param to computeChatThreadReportName and forward it to getForReportActionTemp so policy-admin MCC checks can run correctly. - Pass reportPolicy from computeReportName into computeChatThreadReportName. - Add comment explaining the currentUserLogin empty-string limitation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0b22f63 to
f066f6b
Compare
|
@leshniak you didn't link the issue correctly so the reviewers didn't get added right, I'll do that now |
|
@tgolen added you since Daniel is OOO |
@madmax330 oh, I'm sorry - is this because the lack of space after |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
05.03.2026_23.11.32_REC.mp4
🎀 👀 🎀 C+ reviewed
02bab6f to
f066f6b
Compare
|
@parasharrajat Looks like the GH action is failing for your PR reviewer checklist. Can you look into that? Maybe you have an outdate list or something. |
|
All set @tgolen |
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.33-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀
|
Explanation of Change
ReportNameUtils.computeChatThreadReportNamepreviously relied ongetForReportActionTempwhich fetchedpolicyTagsinternally viaOnyx.connectWithoutView. This PR makespolicyTagsan explicit parameter so the function is a pure, testable utility.computeChatThreadReportNamenow acceptspolicyTags: OnyxEntry<PolicyTagLists>and forwards it togetForReportActionTempgetComputedReportNamethreads the new param from its callersThis PR is part of the work split from #75562.
Fixed Issues
$#66336
PROPOSAL:
Tests
Offline tests
N/A — pure refactor, no network calls added or removed.
QA Steps
N/A — no user-visible behavior change. This is a pure internal refactor that passes data as function parameters instead of reading it from a module-level Onyx subscription.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvatar8000 is working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — no UI changes
Android: mWeb Chrome
N/A — no UI changes
iOS: Native
N/A — no UI changes
iOS: mWeb Safari
N/A — no UI changes
MacOS: Chrome / Safari
N/A — no UI changes