[Part 3e] Propagate policyTags to ReportNameUtils callers via reportAttributes#83897
Merged
tgolen merged 7 commits intoExpensify:mainfrom Mar 11, 2026
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
50 tasks
752eb2f to
f4eae2c
Compare
50 tasks
17ad391 to
0e55971
Compare
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
There was a problem hiding this comment.
No product review is required on this one.
Keep ReportNameUtils backward compatible while enabling the temporary modified-expense formatter when policy tags are available, and add unit coverage for the tagged thread-name flow. Made-with: Cursor
Address the no-unused-vars lint error introduced by the temporary policyTags parameter and keep the extraction branch passing repository lint/prettier checks. Made-with: Cursor
Pass the required currentUserLogin argument to getForReportActionTemp so the extraction branch passes repository typecheck, lint, and prettier checks. Made-with: Cursor
The parameter is reserved for the upcoming caller-propagation step and intentionally unused yet. Replace the redundant early-return guard with an explicit eslint-disable comment to make that intent clear. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ion and pass policy through computeChatThreadReportName - Remove _policyTags from computeReportNameBasedOnReportAction; the function handles SUBMITTED/HOLD/IOU actions, none of which use policy tags. The modified-expense path lives entirely in computeChatThreadReportName. - Add policy param to computeChatThreadReportName and forward it to getForReportActionTemp so policy-admin MCC checks can run correctly. - Pass reportPolicy from computeReportName into computeChatThreadReportName. - Add comment explaining the currentUserLogin empty-string limitation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…yTags to computeReportName Wire POLICY_TAGS into the reportAttributes OnyxDerived config so per-report policy tags are available at derivation time and forwarded to computeReportName. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
612067a to
0e55971
Compare
parasharrajat
approved these changes
Mar 7, 2026
Member
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
07.03.2026_15.49.28_REC.mp4
🎀 👀 🎀 C+ reviewed
Member
|
cc: @tgolen for review. @tgolen Can you please reassign yourself to the issue instead @danieldoglas So that you get tagged to all upcoming PRs. |
tgolen
previously approved these changes
Mar 9, 2026
Contributor
|
@leshniak Can you please try updating your branch from 
|
Contributor
Author
I'll start with it tomorrow. |
…callers-policytags Resolve conflicts adapting to upstream refactoring of computeReportName to object params (ComputeReportName type) and addition of currentUserLogin. - computeReportName now uses object destructuring; allPolicyTags wired in - computeChatThreadReportName now receives currentUserLogin from params - reportAttributes.ts passes allPolicyTags in the new object call syntax - Test updated to use upstream's object-param call signature Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0e55971 to
d1025b4
Compare
Contributor
Author
|
@tgolen the branch is updated. |
tgolen
approved these changes
Mar 11, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.36-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
After #83930 made
computeChatThreadReportNameacceptpolicyTags, this PR wires the actual data in. ThereportAttributesOnyxDerived computation now subscribes toPOLICY_TAGSand resolves the correctPolicyTagListsentry per report before callinggetComputedReportName.reportAttributes.tsaddsONYXKEYS.COLLECTION.POLICY_TAGSsubscription, extracts per-report tags, and passes them togetComputedReportNameReportNameUtils.tsremoves thepolicyForMovingExpensesIDfallback no longer needed once real tags are providedOnyxDerivedTestupdated to verify policyTags are correctly threaded throughThis PR is part of the work split from #75562.
Fixed Issues
$#66336
PROPOSAL:
Tests
Offline tests
N/A — pure refactor, no network calls added or removed.
QA Steps
N/A — no user-visible behavior change. This is a pure internal refactor that passes data as function parameters instead of reading it from a module-level Onyx subscription.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — no UI changes
Android: mWeb Chrome
N/A — no UI changes
iOS: Native
N/A — no UI changes
iOS: mWeb Safari
N/A — no UI changes
MacOS: Chrome / Safari
N/A — no UI changes