feature/avgpool - avgpool1d, avgpool2d, avgpool3d #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gbaydin This is ready - testing for tensors and derivatives have been added The reverse mode derivatives have been checked against python. I've forgotten the python for checking the forward mode derivatives but I've pinned them down (and the forward mode implementations are trivial of course) |
22 tasks
|
close/reopen to trigger CI |
Codecov Report
@@ Coverage Diff @@
## dev #252 +/- ##
==========================================
- Coverage 66.01% 65.22% -0.79%
==========================================
Files 5 30 +25
Lines 2401 6849 +4448
Branches 641 1668 +1027
==========================================
+ Hits 1585 4467 +2882
- Misses 520 1526 +1006
- Partials 296 856 +560
|
Merged
|
@gbaydin I've rebased this so it now uses the new extension API It should be ready to go in once green |
|
I checked everything carefully and this is good to go! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds avgpool support
@gbaydin this uses the updated #89 to stop polluting Tensor,fs, and to have
DiffSharp.AvgPool.fsextend all the necessary API surfacings all at once